Bug 192660 - Improve GDB output for LLInt on Linux
Summary: Improve GDB output for LLInt on Linux
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-13 01:31 PST by Dominik Inführ
Modified: 2018-12-13 23:18 PST (History)
8 users (show)

See Also:


Attachments
Patch (2.82 KB, patch)
2018-12-13 01:43 PST, Dominik Inführ
no flags Details | Formatted Diff | Diff
Patch (2.88 KB, patch)
2018-12-13 04:08 PST, Dominik Inführ
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Inführ 2018-12-13 01:31:11 PST
Improve GDB output for LLInt on Linux
Comment 1 Dominik Inführ 2018-12-13 01:43:15 PST
Created attachment 357220 [details]
Patch
Comment 2 Yusuke Suzuki 2018-12-13 02:40:21 PST
Comment on attachment 357220 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357220&action=review

> Source/JavaScriptCore/offlineasm/arm.rb:687
> +            offsetLabel = ".L_offlineasm_arm_got_offset_#{uid}"

Does this break OS(DARWIN)? See wtf/InlineASM.h's LOCAL_LABEL_STRING definition.
Comment 3 Dominik Inführ 2018-12-13 04:08:12 PST
Created attachment 357223 [details]
Patch
Comment 4 Dominik Inführ 2018-12-13 04:11:46 PST
True, I didn't expect it to be used on OS(DARWIN) since I've only added `globaladdr` for ARM recently. But I've updated it to use `Assembler.localLabellReference`, should be a bit simpler.
Comment 5 Yusuke Suzuki 2018-12-13 07:29:24 PST
Comment on attachment 357223 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2018-12-13 23:17:39 PST
Comment on attachment 357223 [details]
Patch

Clearing flags on attachment: 357223

Committed r239199: <https://trac.webkit.org/changeset/239199>
Comment 7 WebKit Commit Bot 2018-12-13 23:17:41 PST
All reviewed patches have been landed.  Closing bug.