Bug 192638 - [macOS] Inline WebVTT styles should override styles from Captions settings in System Preferences
Summary: [macOS] Inline WebVTT styles should override styles from Captions settings in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-12 13:44 PST by Per Arne Vollan
Modified: 2018-12-13 15:06 PST (History)
4 users (show)

See Also:

Attachments
Patch (11.29 KB, patch)
2018-12-12 14:00 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (11.81 KB, patch)
2018-12-12 15:05 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (11.82 KB, patch)
2018-12-12 16:24 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2018-12-12 13:44:58 PST 
It should be possible to override styles generated from Captions settings in System Preferences with inline WebVTT styles when ‘Allow video to override’ is checked in System Preferences.
Comment 1 Per Arne Vollan 2018-12-12 13:45:19 PST 
rdar://problem/46421091
Comment 2 Per Arne Vollan 2018-12-12 14:00:00 PST 
Created attachment 357165 [details]
Patch
Comment 3 Per Arne Vollan 2018-12-12 15:05:27 PST 
Created attachment 357172 [details]
Patch
Comment 4 Per Arne Vollan 2018-12-12 16:24:38 PST 
Created attachment 357190 [details]
Patch
Comment 5 Per Arne Vollan 2018-12-13 14:40:13 PST 
Comment on attachment 357190 [details]
Patch

Thanks for reviewing!
Comment 6 WebKit Commit Bot 2018-12-13 15:06:56 PST 
Comment on attachment 357190 [details]
Patch

Clearing flags on attachment: 357190

Committed r239181: <https://trac.webkit.org/changeset/239181>
Comment 7 WebKit Commit Bot 2018-12-13 15:06:57 PST 
All reviewed patches have been landed.  Closing bug.