Bug 192630 - Don't attempt to animate invalid CSS properties
Summary: Don't attempt to animate invalid CSS properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-12 09:38 PST by Brent Fulgham
Modified: 2018-12-13 12:30 PST (History)
10 users (show)

See Also:

Attachments
Patch (4.33 KB, patch)
2018-12-12 09:51 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (3.81 KB, patch)
2018-12-12 09:55 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (3.86 KB, patch)
2018-12-12 12:19 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-12-12 09:38:12 PST 
Inherited animation properties can cause child elements to think they need to animate CSS properties that they do not support, leading to nullptr crashes.

Instead, recognize that CSSPropertyInvalid is a potential requested animation property, and handle it cleanly (much like Animation::AnimateUnknownProperty is already handled).
Comment 1 Radar WebKit Bug Importer 2018-12-12 09:41:36 PST 
<rdar://problem/46664433>
Comment 2 Brent Fulgham 2018-12-12 09:51:48 PST 
Created attachment 357146 [details]
Patch
Comment 3 Brent Fulgham 2018-12-12 09:55:39 PST 
Created attachment 357147 [details]
Patch
Comment 4 Dean Jackson 2018-12-12 10:19:42 PST 
Comment on attachment 357147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357147&action=review

> LayoutTests/animations/invalid-property-animation.html:9
> +    document.designMode = "off";

Supposedly not needed.
Comment 5 Brent Fulgham 2018-12-12 12:19:32 PST 
Created attachment 357156 [details]
Patch
Comment 6 Brent Fulgham 2018-12-13 12:04:14 PST 
Thank you, Antoine!
Comment 7 WebKit Commit Bot 2018-12-13 12:30:09 PST 
Comment on attachment 357156 [details]
Patch

Clearing flags on attachment: 357156

Committed r239174: <https://trac.webkit.org/changeset/239174>
Comment 8 WebKit Commit Bot 2018-12-13 12:30:10 PST 
All reviewed patches have been landed.  Closing bug.