Bug 192625 - [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
Summary: [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-12 07:49 PST by zalan
Modified: 2019-01-09 08:09 PST (History)
4 users (show)

See Also:

Attachments
Patch (79.47 KB, patch)
2018-12-12 08:00 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (67.00 KB, patch)
2018-12-16 18:00 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (124.13 KB, patch)
2018-12-29 08:46 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (110.67 KB, patch)
2018-12-29 09:13 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (111.87 KB, patch)
2018-12-29 18:12 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (83.76 KB, patch)
2018-12-29 18:23 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (111.33 KB, patch)
2018-12-29 20:06 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (92.56 KB, patch)
2019-01-05 21:21 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (85.22 KB, patch)
2019-01-06 21:48 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (87.13 KB, patch)
2019-01-08 07:47 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (90.37 KB, patch)
2019-01-08 21:32 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (10) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-12-12 07:49:15 PST 
name a couple:
If the top and bottom margins of an element with clearance are adjoining, its margins collapse with the adjoining margins of following siblings but that resulting margin does not collapse with the bottom margin of the parent block.

If the top margin of a box with non-zero computed 'min-height' and 'auto' computed 'height' collapses with the bottom margin of its last in-flow child, then the child's bottom margin does not collapse with the parent's bottom margin.
Comment 1 zalan 2018-12-12 08:00:20 PST 
Created attachment 357130 [details]
Patch

WIP. Need to split this into smaller patches.
Comment 2 zalan 2018-12-16 18:00:43 PST 
Created attachment 357423 [details]
Patch

WIP
Comment 3 zalan 2018-12-29 08:46:24 PST 
Created attachment 358137 [details]
Patch
Comment 4 zalan 2018-12-29 09:13:08 PST 
Created attachment 358138 [details]
Patch
Comment 5 zalan 2018-12-29 18:12:49 PST 
Created attachment 358142 [details]
Patch
Comment 6 zalan 2018-12-29 18:23:12 PST 
Created attachment 358143 [details]
Patch
Comment 7 zalan 2018-12-29 20:06:06 PST 
Created attachment 358144 [details]
Patch
Comment 8 zalan 2019-01-05 21:21:52 PST 
Created attachment 358455 [details]
Patch
Comment 9 zalan 2019-01-06 21:48:00 PST 
Created attachment 358479 [details]
Patch
Comment 10 zalan 2019-01-08 07:47:25 PST 
Created attachment 358589 [details]
Patch
Comment 11 zalan 2019-01-08 21:32:59 PST 
Created attachment 358670 [details]
Patch
Comment 12 Antti Koivisto 2019-01-09 07:33:05 PST 
Comment on attachment 358670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358670&action=review

> Source/WebCore/layout/MarginTypes.h:79
> +struct EstimatedMarginBefore {
> +    LayoutUnit usedValue;
> +};

I suppose this will have more stuff later?
Comment 13 WebKit Commit Bot 2019-01-09 08:08:13 PST 
Comment on attachment 358670 [details]
Patch

Clearing flags on attachment: 358670

Committed r239773: <https://trac.webkit.org/changeset/239773>
Comment 14 WebKit Commit Bot 2019-01-09 08:08:15 PST 
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2019-01-09 08:09:30 PST 
<rdar://problem/47146753>