Bug 192619 - [BigInt] Implement DFG/FTL typeof for BigInt
Summary: [BigInt] Implement DFG/FTL typeof for BigInt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-12 02:00 PST by Yusuke Suzuki
Modified: 2018-12-12 18:03 PST (History)
7 users (show)

See Also:

Attachments
Patch (9.03 KB, patch)
2018-12-12 02:02 PST, Yusuke Suzuki 		keith_miller: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-12-12 02:00:02 PST 
[BigInt] Implement DFG/FTL typeof for BigInt
Comment 1 Yusuke Suzuki 2018-12-12 02:02:57 PST 
Created attachment 357114 [details]
Patch
Comment 2 Caio Lima 2018-12-12 05:21:42 PST 
Comment on attachment 357114 [details]
Patch

LGTM, informal r+
Comment 3 Keith Miller 2018-12-12 10:57:13 PST 
Comment on attachment 357114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357114&action=review

r=me.

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:14220
> +        //     } else if (is bigint) {

Do we think that bigints are going to be more or less common than symbol? 

Also, when we add a value representation for "small big ints" I would expect symbols would be more common. Can we add a FIXME: here to switch the ordering when that happens?

> Source/JavaScriptCore/jit/AssemblyHelpers.h:1658
> +        //     } else if (is bigint) {
> +        //         return bigint

Ditto
Comment 4 Yusuke Suzuki 2018-12-12 17:58:19 PST 
Comment on attachment 357114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357114&action=review

Thank you!

>> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:14220
>> +        //     } else if (is bigint) {
> 
> Do we think that bigints are going to be more or less common than symbol? 
> 
> Also, when we add a value representation for "small big ints" I would expect symbols would be more common. Can we add a FIXME: here to switch the ordering when that happens?

Make sense. Added FIXME here.

>> Source/JavaScriptCore/jit/AssemblyHelpers.h:1658
>> +        //         return bigint
> 
> Ditto

Fixed.
Comment 5 Yusuke Suzuki 2018-12-12 18:01:42 PST 
Committed r239141: <https://trac.webkit.org/changeset/239141>
Comment 6 Radar WebKit Bug Importer 2018-12-12 18:03:48 PST 
<rdar://problem/46683130>