Bug 192610 - Implement feature flag for CSS Typed OM
Summary: Implement feature flag for CSS Typed OM
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Michaud
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-11 20:20 PST by Justin Michaud
Modified: 2019-01-07 15:17 PST (History)
8 users (show)

See Also:

Attachments
Patch (66.11 KB, patch)
2018-12-11 20:26 PST, Justin Michaud 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Michaud 2018-12-11 20:20:31 PST 
Give the CSS Typed OM its own feature flag.
Comment 1 Justin Michaud 2018-12-11 20:26:25 PST 
Created attachment 357098 [details]
Patch
Comment 2 WebKit Commit Bot 2018-12-11 21:54:25 PST 
Comment on attachment 357098 [details]
Patch

Clearing flags on attachment: 357098

Committed r239098: <https://trac.webkit.org/changeset/239098>
Comment 3 WebKit Commit Bot 2018-12-11 21:54:26 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-12-11 21:55:28 PST 
<rdar://problem/46652147>
Comment 5 Claudio Saavedra 2019-01-07 07:29:32 PST 
Isn't the feature flag missing from WebKitFeatures.cmake?
Comment 6 Don Olmstead 2019-01-07 08:50:05 PST 
(In reply to Claudio Saavedra from comment #5)
> Isn't the feature flag missing from WebKitFeatures.cmake?

It is I can add it. I think there are a couple other flags that got added that are missing from CMake now.
Comment 7 Don Olmstead 2019-01-07 15:17:13 PST 
https://bugs.webkit.org/show_bug.cgi?id=193216