Bug 192591 - Don't attempt to compute animated values when there is no relevant animation
Summary: Don't attempt to compute animated values when there is no relevant animation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-11 09:03 PST by Brent Fulgham
Modified: 2018-12-11 14:34 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.38 KB, patch)
2018-12-11 09:07 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch (6.25 KB, patch)
2018-12-11 13:26 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-12-11 09:03:36 PST
We see nullptr errors in SVGAnimateElementBase::calculateAnimatedValue because it attempts to calculate the animation value of a property that is not being animated.

WebKit does the right thing when setting the animation type, but when animation values are requested, we ignore the fact that the property is either (a) not supposed to be animated, or (b) has no animated properties, and attempt to use the nullptr value to check the result.

We should bail out early if an animation value is requested for a property that is not being animated.
Comment 1 Brent Fulgham 2018-12-11 09:04:59 PST
<rdar://problem/34336946>
Comment 2 Brent Fulgham 2018-12-11 09:07:01 PST
Created attachment 357052 [details]
Patch
Comment 3 Brent Fulgham 2018-12-11 13:26:25 PST
Created attachment 357072 [details]
Patch
Comment 4 WebKit Commit Bot 2018-12-11 14:34:48 PST
Comment on attachment 357072 [details]
Patch

Clearing flags on attachment: 357072

Committed r239090: <https://trac.webkit.org/changeset/239090>
Comment 5 WebKit Commit Bot 2018-12-11 14:34:49 PST
All reviewed patches have been landed.  Closing bug.