Bug 192589 - [FreeType] Remove HarfBuzzFace
Summary: [FreeType] Remove HarfBuzzFace
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk, InRadar
Depends on: 192151
  Show dependency treegraph
Reported: 2018-12-11 06:50 PST by Carlos Garcia Campos
Modified: 2018-12-13 01:43 PST (History)
4 users (show)

See Also:

Patch (45.12 KB, patch)
2018-12-11 06:58 PST, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff
Patch for landing (45.08 KB, patch)
2018-12-13 01:20 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-12-11 06:50:13 PST
This was used to share the common implementation with the chromium port, but now that only freetype based ports use it, it can be removed and use hb_ft_face_create_cached() instead. We don't need the glyph cache either, since we are already caching glyphs in Font.
Comment 1 Carlos Garcia Campos 2018-12-11 06:58:04 PST
Created attachment 357047 [details]
Comment 2 Carlos Garcia Campos 2018-12-11 06:58:28 PST
I wrote this patch on top of patch attached to bug #192151
Comment 3 Michael Catanzaro 2018-12-11 14:58:35 PST
Comment on attachment 357047 [details]

Probably goes without saying, but you should see if Myles has comments before landing this.
Comment 4 Carlos Garcia Campos 2018-12-12 01:19:56 PST
Committed r239101: <https://trac.webkit.org/changeset/239101>
Comment 5 Radar WebKit Bug Importer 2018-12-12 01:21:27 PST
Comment 6 Michael Catanzaro 2018-12-12 11:05:37 PST
Reopening. I rolled this out in r239122 because it depends on bug #192151.
Comment 7 Carlos Garcia Campos 2018-12-13 01:20:36 PST
Created attachment 357219 [details]
Patch for landing
Comment 8 Carlos Garcia Campos 2018-12-13 01:43:54 PST
Committed r239157: <https://trac.webkit.org/changeset/239157>