Bug 192573 - Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
Summary: Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-10 16:05 PST by Don Olmstead
Modified: 2018-12-10 20:05 PST (History)
15 users (show)

See Also:

Attachments
Patch (44.72 KB, patch)
2018-12-10 16:08 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-12-10 16:05:48 PST 
Currently ENABLE_RESOURCE_LOAD_STATISTICS is defined in Platform.h. This doesn't seem right.

Related discussion on mailing list https://lists.webkit.org/pipermail/webkit-dev/2018-December/030302.html
Comment 1 Don Olmstead 2018-12-10 16:08:47 PST 
Created attachment 357012 [details]
Patch

Testing XCode build.
Comment 2 Michael Catanzaro 2018-12-10 16:10:21 PST 
Comment on attachment 357012 [details]
Patch

Makes sense to get ENABLE_ cruft out of Platform.h. Let's see if EWS is happy with it.
Comment 3 Don Olmstead 2018-12-10 17:28:29 PST 
(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 357012 [details]
> Patch
> 
> Makes sense to get ENABLE_ cruft out of Platform.h. Let's see if EWS is
> happy with it.

EWS seems to be happy with this change. Would be nice to just get a confirmation from someone on the Apple side just in case.
Comment 4 WebKit Commit Bot 2018-12-10 20:04:53 PST 
Comment on attachment 357012 [details]
Patch

Clearing flags on attachment: 357012

Committed r239068: <https://trac.webkit.org/changeset/239068>
Comment 5 WebKit Commit Bot 2018-12-10 20:04:55 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-12-10 20:05:26 PST 
<rdar://problem/46617432>