Bug 192565 - Sync FeatureList.pm
Summary: Sync FeatureList.pm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-10 12:47 PST by Don Olmstead
Modified: 2018-12-10 16:09 PST (History)
9 users (show)

See Also:

Attachments
Patch (21.28 KB, patch)
2018-12-10 12:49 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-12-10 12:47:29 PST 
Follow up with https://bugs.webkit.org/show_bug.cgi?id=191167 to do the same with FeatureList.pm
Comment 1 Don Olmstead 2018-12-10 12:49:31 PST 
Created attachment 356985 [details]
Patch
Comment 2 Ross Kirsling 2018-12-10 13:41:59 PST 
Comment on attachment 356985 [details]
Patch

Comparing to WebKitFeatures.cmake, it looks like you're missing three:

ENABLE_API_TESTS
ENABLE_C_LOOP
ENABLE_MINIBROWSER

Is this intentional?
Comment 3 Don Olmstead 2018-12-10 13:49:38 PST 
(In reply to Ross Kirsling from comment #2)
> Comment on attachment 356985 [details]
> Patch
> 
> Comparing to WebKitFeatures.cmake, it looks like you're missing three:
> 
> ENABLE_API_TESTS
> ENABLE_C_LOOP
> ENABLE_MINIBROWSER
> 
> Is this intentional?

Yes. ENABLE_C_LOOP is really dependent on the target hardware. Minibrowser is dependent on the port. Maybe API tests should be an option but I feel it would be better covered by a specific flag.
Comment 4 WebKit Commit Bot 2018-12-10 16:08:17 PST 
Comment on attachment 356985 [details]
Patch

Clearing flags on attachment: 356985

Committed r239058: <https://trac.webkit.org/changeset/239058>
Comment 5 WebKit Commit Bot 2018-12-10 16:08:19 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-12-10 16:09:27 PST 
<rdar://problem/46612077>