NEW192561
Merge wtf/EventLoop and WebCore EventLoop, and rename it
https://bugs.webkit.org/show_bug.cgi?id=192561
Summary Merge wtf/EventLoop and WebCore EventLoop, and rename it
Simon Fraser (smfr)
Reported 2018-12-10 11:22:24 PST
We have EventLoop in both JSC and WebCore. Almost everything seems to use the JSC one, but PageScriptDebugServer::runEventLoopWhilePausedInternal() uses WebCore::EventLoop. The name “EventLoop” is in demand for HTML5 Event Loop stuff, so I’d like to free up this name if possible. I also think we should rename JSC::EventLoop to something more inspector-specific, since it isn’t a full EventLoop implementation. Can we even move its functionality into the RunLoop class? Joe says: > Sure we could easily rename these to be DebuggerRunLoop to free up the name. > It could probably also move to the RunLoop class. There are some differences between the JSC one and the WebCore one which I believe are still important. But maybe one of the implementations can move down into WTF.
Attachments
Note You need to log in before you can comment on or make changes to this bug.