Bug 192521 - Animated scrolling on Google Maps scrolls the page in addition to moving the map
Summary: Animated scrolling on Google Maps scrolls the page in addition to moving the map
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-07 15:45 PST by Tim Horton
Modified: 2018-12-10 16:32 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.64 KB, patch)
2018-12-07 15:45 PST, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-12-07 15:45:41 PST
Animated scrolling on Google Maps scrolls the page in addition to moving the map
Comment 1 Tim Horton 2018-12-07 15:45:48 PST
Created attachment 356846 [details]
Patch
Comment 2 Tim Horton 2018-12-07 15:45:49 PST
<rdar://problem/46382007>
Comment 3 Sam Weinig 2018-12-07 20:20:49 PST
Comment on attachment 356846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356846&action=review

> Source/WebKit/ChangeLog:14
> +        * UIProcess/ios/WKKeyboardScrollingAnimator.mm:
> +        (-[WKKeyboardScrollViewAnimator rubberbandableDirections]):
> +        Only do keyboard-based rubber-banding in directions that we can actually
> +        scroll, not directions we can only finger-rubber-band in. This effectively
> +        means keyboard scrolling will ignore "alwaysBounce{Vertical, Horizontal}".

Is there any way to test this?
Comment 4 Tim Horton 2018-12-10 16:23:09 PST
This is one of those things where it's a bit tricky to make a layout test to prove the non-existence of something (e.g. a scroll event) without being slow or flaky. Maybe possible to API test instead.
Comment 5 WebKit Commit Bot 2018-12-10 16:32:46 PST
Comment on attachment 356846 [details]
Patch

Clearing flags on attachment: 356846

Committed r239059: <https://trac.webkit.org/changeset/239059>
Comment 6 WebKit Commit Bot 2018-12-10 16:32:48 PST
All reviewed patches have been landed.  Closing bug.