Bug 192510 - [ews-build] check-patch-relevance failure should not mark the overall build as failure
Summary: [ews-build] check-patch-relevance failure should not mark the overall build a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-07 12:35 PST by Aakash Jain
Modified: 2018-12-08 05:04 PST (History)
4 users (show)

See Also:

Attachments
Proposed patch (1.16 KB, patch)
2018-12-07 12:37 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-12-07 12:35:40 PST 
When a check-patch-relevance step fails, it indicate that the patch doesn't have changes relevant to the builder, and therefore rest of the processing is skipped.

Therefore failure in check-patch-relevance step should not mark the build as failure, instead the build should be marked as SKIPPED.
Comment 1 Aakash Jain 2018-12-07 12:37:41 PST 
Created attachment 356830 [details]
Proposed patch

Sample run: http://ews-build.webkit-uat.org/#/builders/16/builds/229
Comment 2 Aakash Jain 2018-12-08 05:03:43 PST 
Committed r239008: <https://trac.webkit.org/changeset/239008>
Comment 3 Radar WebKit Bug Importer 2018-12-08 05:04:34 PST 
<rdar://problem/46574892>