Bug 192508 - [iOS] Make WebGPU work with remote layer hosting
Summary: [iOS] Make WebGPU work with remote layer hosting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-07 11:49 PST by Dean Jackson
Modified: 2018-12-10 11:38 PST (History)
7 users (show)

See Also:

Attachments
Patch (14.95 KB, patch)
2018-12-07 11:59 PST, Dean Jackson 		thorton: review+
Details | Formatted Diff | Diff
Patch (15.25 KB, patch)
2018-12-07 12:13 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2018-12-07 11:49:00 PST 
[iOS] Make WebGPU work with remote layer hosting
Comment 1 Radar WebKit Bug Importer 2018-12-07 11:49:46 PST 
<rdar://problem/46560649>
Comment 2 Dean Jackson 2018-12-07 11:59:28 PST 
Created attachment 356827 [details]
Patch
Comment 3 Tim Horton 2018-12-07 12:03:35 PST 
Comment on attachment 356827 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356827&action=review

> Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:41
> +#if ENABLE(WEBGPU)

In its own paragraph!

> Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:46
>  #if ENABLE(WEBMETAL)

Ditto

> Source/WebCore/platform/graphics/cocoa/WebGPULayer.h:38
> +    float _devicePixelRatio;

Native-y code doesn't usually use the webby "devicePixelRatio" but usually "deviceScaleFactor"

> Source/WebCore/platform/graphics/cocoa/WebGPULayer.h:43
> +- (id)init;

Why?
Comment 4 Dean Jackson 2018-12-07 12:13:12 PST 
Created attachment 356828 [details]
Patch
Comment 5 Dean Jackson 2018-12-07 13:10:44 PST 
Committed r238965: <https://trac.webkit.org/changeset/238965>
Comment 6 Truitt Savell 2018-12-10 09:17:31 PST 
Reverted r238965 for reason:

Caused internal iOS build failures

Committed r239031: <https://trac.webkit.org/changeset/239031>
Comment 7 Dean Jackson 2018-12-10 11:38:03 PST 
Committed r239036: <https://trac.webkit.org/changeset/239036>