Bug 192497 – Fix build on 64bit ARM with arm64 SYSTEM_PROCESSOR

• Status: RESOLVED
• Resolution: FIXED
• Component: CMake

[Lucas Stach]

Created attachment 356802 [details]
Suggested patch to fix ARM64 build

Android and some embedded Linux build systems use arm64 instead of aarch64 as the CMAKE_HOST_PROCESSOR. This patch fixes the JIT build in this scenario.

[Philippe Normand]

Thanks for the patch! (Unfortunately) a ChangeLog is required though, the contributor workflow is quite well explained in https://webkit.org/contributing-code/

[Lucas Stach]

Created attachment 356805 [details]
Patch

[EWS Watchlist]

Attachment 356805 [details] did not pass style-queue:


ERROR: ChangeLog:4:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Philippe Normand]

Comment on attachment 356805 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356805&action=review

> ChangeLog:6
> +        Android and some embedded Linux build systems use arm64 instead of
> +	aarch64 as the CMAKE_HOST_PROCESSOR. Fix JIT build for this scenario.
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=192497

Usually the format is:
"""
bug title as in Bugzilla
Bugzilla link

Explanation of the changes
"""

[Don Olmstead]

Created attachment 357593 [details]
Patch

Hi Lucas,

I'm attaching a Changelog that will pass the style checker. As Phillipe mentioned the workflow is explained https://webkit.org/contributing-code for future reference.

[EWS Watchlist]

Comment on attachment 357593 [details]
Patch

Attachment 357593 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10462296

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html

[EWS Watchlist]

Created attachment 357607 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Philippe Normand]

Comment on attachment 357593 [details]
Patch

Thanks Dom!

[WebKit Commit Bot]

Comment on attachment 357593 [details]
Patch

Clearing flags on attachment: 357593

Committed r239378: <https://trac.webkit.org/changeset/239378>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.