Bug 192492 - [ews-build] Builds should have a link to patch and bug
Summary: [ews-build] Builds should have a link to patch and bug
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-07 02:33 PST by Aakash Jain
Modified: 2018-12-07 10:52 PST (History)
8 users (show)

See Also:

Attachments
Proposed patch (2.46 KB, patch)
2018-12-07 02:37 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Proposed patch (2.46 KB, patch)
2018-12-07 02:47 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-sierra-wk2 (3.28 MB, application/zip)
2018-12-07 04:48 PST, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-12-07 02:33:26 PST 
Buildbot builds in ews-build.webkit.org should have a link to the corresponding patch and bug. This would make it easy to correlate build with the corresponding patch/bug.
Comment 1 Aakash Jain 2018-12-07 02:37:36 PST 
Created attachment 356791 [details]
Proposed patch
Comment 2 EWS Watchlist 2018-12-07 02:40:34 PST 
Attachment 356791 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:86:  trailing whitespace  [pep8/W291] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:91:  trailing whitespace  [pep8/W291] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Aakash Jain 2018-12-07 02:47:15 PST 
Created attachment 356792 [details]
Proposed patch
Comment 4 Aakash Jain 2018-12-07 02:52:36 PST 
Sample run: http://ews-build.webkit-uat.org/#/builders/5/builds/205  (Notice the links in configure-build step)
Comment 5 EWS Watchlist 2018-12-07 04:48:05 PST 
Comment on attachment 356792 [details]
Proposed patch

Attachment 356792 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10303596

New failing tests:
fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolling-layers-state.html
Comment 6 EWS Watchlist 2018-12-07 04:48:06 PST 
Created attachment 356801 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 WebKit Commit Bot 2018-12-07 10:51:50 PST 
Comment on attachment 356792 [details]
Proposed patch

Clearing flags on attachment: 356792

Committed r238959: <https://trac.webkit.org/changeset/238959>
Comment 8 WebKit Commit Bot 2018-12-07 10:51:52 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-12-07 10:52:37 PST 
<rdar://problem/46558523>