Bug 192490 - webkitpy: WinCairoPort.default_child_processes should return the appropriate default number of DumpRenderTree processes
Summary: webkitpy: WinCairoPort.default_child_processes should return the appropriate ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-07 01:13 PST by Fujii Hironori
Modified: 2018-12-10 00:20 PST (History)
1 user (show)

See Also:


Attachments
WIP patch (2.21 KB, patch)
2018-12-10 00:19 PST, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-12-07 01:13:49 PST
webkitpy: WinCairoPort.default_child_processes should return the appropriate default number of DumpRenderTree processes

As discussed in Bug 192486, it should be based on the number of CPU and RAM size.

Mac port has such implementation.
https://github.com/WebKit/webkit/blob/9e192ff36b8e90d6361dae8b1e3022aa5c0d83e9/Tools/Scripts/webkitpy/port/mac.py#L191
Comment 1 Fujii Hironori 2018-12-09 23:59:32 PST
Here is the return value of win32api.GlobalMemoryStatusEx() on WinCairo Docker container.

> {'TotalPageFile': 39459540992L, 'AvailVirtual': 140737373986816L, 'MemoryLoad': 30, 'TotalPhys': 34359267328L, 'AvailExtendedVirtual': 0L, 'Length': 64, 'TotalVrtual': 140737488224256L, 'AvailPhys': 23751901184L, 'AvailPageFile': 29975863296L}

Here is the one on my PC.

> {'TotalPageFile': 39389532160L, 'AvailVirtual': 140733064794112L, 'MemoryLoad': 25, 'TotalPhys': 34289258496L, 'AvailExtendedVirtual': 0L, 'Length': 64, 'TotalVirtual': 140737488224256L, 'AvailPhys': 25691299840L, 'AvailPageFile': 26506842112L}

The Docker container says it has enough RAM.
Umm, I can't use this approach for Bug 188036.
Comment 2 Fujii Hironori 2018-12-10 00:19:28 PST
Created attachment 356948 [details]
WIP patch
Comment 3 Fujii Hironori 2018-12-10 00:20:13 PST
How can Python script know if it is run on a Docker container?