Bug 192489 - Add keychain access entitlement to WebKitTestRunnerApp
Summary: Add keychain access entitlement to WebKitTestRunnerApp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-06 22:46 PST by Jiewen Tan
Modified: 2018-12-07 15:14 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.46 KB, patch)
2018-12-06 22:52 PST, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2018-12-06 22:46:08 PST 
Add keychain access entitlement to WebKitTestRunnerApp.
Comment 1 Jiewen Tan 2018-12-06 22:46:33 PST 
<rdar://problem/45057952>
Comment 2 Jiewen Tan 2018-12-06 22:52:22 PST 
Created attachment 356784 [details]
Patch
Comment 3 Alexey Proskuryakov 2018-12-07 10:53:50 PST 
Comment on attachment 356784 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356784&action=review

> Tools/ChangeLog:3
> +        Add keychain access entitlement to WebKitTestRunnerApp

Does this fix tests?
Comment 4 Jiewen Tan 2018-12-07 11:03:50 PST 
Comment on attachment 356784 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356784&action=review

>> Tools/ChangeLog:3
>> +        Add keychain access entitlement to WebKitTestRunnerApp
> 
> Does this fix tests?

Yes, it does. The error is about WebKitTestRunnerApp don't have the entitlement to query Keychain.

iOS simulator always has some weird settings other than real devices.
Comment 5 Alexey Proskuryakov 2018-12-07 11:18:11 PST 
Are there any tests that should be unskipped with this change?
Comment 6 Jiewen Tan 2018-12-07 11:38:29 PST 
(In reply to Alexey Proskuryakov from comment #5)
> Are there any tests that should be unskipped with this change?

Those expectations are within internal.
Comment 7 Jiewen Tan 2018-12-07 14:52:12 PST 
Comment on attachment 356784 [details]
Patch

Thanks Alexey for r+ this patch.
Comment 8 WebKit Commit Bot 2018-12-07 15:14:51 PST 
Comment on attachment 356784 [details]
Patch

Clearing flags on attachment: 356784

Committed r238970: <https://trac.webkit.org/changeset/238970>
Comment 9 WebKit Commit Bot 2018-12-07 15:14:53 PST 
All reviewed patches have been landed.  Closing bug.