WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
192489
Add keychain access entitlement to WebKitTestRunnerApp
https://bugs.webkit.org/show_bug.cgi?id=192489
Summary
Add keychain access entitlement to WebKitTestRunnerApp
Jiewen Tan
Reported
2018-12-06 22:46:08 PST
Add keychain access entitlement to WebKitTestRunnerApp.
Attachments
Patch
(1.46 KB, patch)
2018-12-06 22:52 PST
,
Jiewen Tan
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jiewen Tan
Comment 1
2018-12-06 22:46:33 PST
<
rdar://problem/45057952
>
Jiewen Tan
Comment 2
2018-12-06 22:52:22 PST
Created
attachment 356784
[details]
Patch
Alexey Proskuryakov
Comment 3
2018-12-07 10:53:50 PST
Comment on
attachment 356784
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=356784&action=review
> Tools/ChangeLog:3 > + Add keychain access entitlement to WebKitTestRunnerApp
Does this fix tests?
Jiewen Tan
Comment 4
2018-12-07 11:03:50 PST
Comment on
attachment 356784
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=356784&action=review
>> Tools/ChangeLog:3 >> + Add keychain access entitlement to WebKitTestRunnerApp > > Does this fix tests?
Yes, it does. The error is about WebKitTestRunnerApp don't have the entitlement to query Keychain. iOS simulator always has some weird settings other than real devices.
Alexey Proskuryakov
Comment 5
2018-12-07 11:18:11 PST
Are there any tests that should be unskipped with this change?
Jiewen Tan
Comment 6
2018-12-07 11:38:29 PST
(In reply to Alexey Proskuryakov from
comment #5
)
> Are there any tests that should be unskipped with this change?
Those expectations are within internal.
Jiewen Tan
Comment 7
2018-12-07 14:52:12 PST
Comment on
attachment 356784
[details]
Patch Thanks Alexey for r+ this patch.
WebKit Commit Bot
Comment 8
2018-12-07 15:14:51 PST
Comment on
attachment 356784
[details]
Patch Clearing flags on attachment: 356784 Committed
r238970
: <
https://trac.webkit.org/changeset/238970
>
WebKit Commit Bot
Comment 9
2018-12-07 15:14:53 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug