Bug 192478 - Web Inspector: remove DOM.BackendNodeId and associated commands/events
Summary: Web Inspector: remove DOM.BackendNodeId and associated commands/events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-06 15:41 PST by Devin Rousso
Modified: 2018-12-13 15:21 PST (History)
11 users (show)

See Also:


Attachments
Patch (39.38 KB, patch)
2018-12-06 15:46 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-12-06 15:41:59 PST
This code hasn't been used in WebInspector for many years now.  We should remove it.
Comment 1 Devin Rousso 2018-12-06 15:46:50 PST
Created attachment 356759 [details]
Patch
Comment 2 EWS Watchlist 2018-12-06 15:48:26 PST
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Comment 3 Matt Baker 2018-12-13 14:54:07 PST
Comment on attachment 356759 [details]
Patch

rs=me
Comment 4 WebKit Commit Bot 2018-12-13 15:20:42 PST
Comment on attachment 356759 [details]
Patch

Clearing flags on attachment: 356759

Committed r239183: <https://trac.webkit.org/changeset/239183>
Comment 5 WebKit Commit Bot 2018-12-13 15:20:44 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-12-13 15:21:26 PST
<rdar://problem/46711547>