Bug 192474 - Content Extensions: Misc fixes to debugging / perf testing code
Summary: Content Extensions: Misc fixes to debugging / perf testing code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-06 13:24 PST by Adrian Perez
Modified: 2018-12-06 14:36 PST (History)
7 users (show)

See Also:


Attachments
Patch (3.99 KB, patch)
2018-12-06 13:28 PST, Adrian Perez
no flags Details | Formatted Diff | Diff
Patch for landing (3.98 KB, patch)
2018-12-06 13:56 PST, Adrian Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2018-12-06 13:24:45 PST
Content Extensions: Misc fixes to debugging / perf testing code
Comment 1 Adrian Perez 2018-12-06 13:28:46 PST
Created attachment 356746 [details]
Patch
Comment 2 Mark Lam 2018-12-06 13:46:49 PST
Comment on attachment 356746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356746&action=review

> Source/WebCore/ChangeLog:9
> +        debuggin features enabled. In particular, building with

/debuggin/debugging/
Comment 3 Adrian Perez 2018-12-06 13:50:16 PST
(In reply to Mark Lam from comment #2)
> Comment on attachment 356746 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=356746&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        debuggin features enabled. In particular, building with
> 
> /debuggin/debugging/

Oh, thanks, I'll fix the typo before landing 👍
Comment 4 Adrian Perez 2018-12-06 13:56:56 PST
Created attachment 356751 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-12-06 14:35:02 PST
Comment on attachment 356751 [details]
Patch for landing

Clearing flags on attachment: 356751

Committed r238942: <https://trac.webkit.org/changeset/238942>
Comment 6 WebKit Commit Bot 2018-12-06 14:35:04 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-12-06 14:36:33 PST
<rdar://problem/46535962>