Bug 192470 - REGRESSION: run-webkit-tests may fail when using booted simulators
Summary: REGRESSION: run-webkit-tests may fail when using booted simulators
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-06 12:38 PST by Jonathan Bedard
Modified: 2018-12-07 13:15 PST (History)
8 users (show)

See Also:

Attachments
Patch (5.78 KB, patch)
2018-12-06 13:22 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (9.79 KB, patch)
2018-12-06 14:11 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2018-12-06 12:38:58 PST 
There are a few edge-cases with <https://bugs.webkit.org/show_bug.cgi?id=192161> when simulators are already booted that the existing code does not cover.
Comment 1 Radar WebKit Bug Importer 2018-12-06 12:39:34 PST 
<rdar://problem/46532001>
Comment 2 Jonathan Bedard 2018-12-06 13:22:23 PST 
Created attachment 356745 [details]
Patch
Comment 3 Ryosuke Niwa 2018-12-06 13:32:39 PST 
Comment on attachment 356745 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356745&action=review

Can we add a test for this?

> Tools/Scripts/webkitpy/port/device_port.py:134
> +        if result != 0 and self.DEVICE_MANAGER == SimulatedDeviceManager:

Nit: We don't compare against 0 per our style guideline.
Comment 4 Jonathan Bedard 2018-12-06 13:45:02 PST 
(In reply to Ryosuke Niwa from comment #3)
> Comment on attachment 356745 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=356745&action=review
> 
> Can we add a test for this?
> ...
>

Not for all of it (anything that interfaces with simctl or actual devices is difficult to test in a cross-platform manner) , but I'll definitely include some.
Comment 5 Jonathan Bedard 2018-12-06 14:11:57 PST 
Created attachment 356753 [details]
Patch
Comment 6 WebKit Commit Bot 2018-12-06 15:21:40 PST 
Comment on attachment 356753 [details]
Patch

Clearing flags on attachment: 356753

Committed r238944: <https://trac.webkit.org/changeset/238944>
Comment 7 WebKit Commit Bot 2018-12-06 15:21:42 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Jonathan Bedard 2018-12-07 13:15:20 PST 
Committed r238966: <https://trac.webkit.org/changeset/238966>