Bug 192465 - [BFC][MarginCollapsing] Extend margin collapsing rules.
Summary: [BFC][MarginCollapsing] Extend margin collapsing rules.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-06 07:44 PST by zalan
Modified: 2018-12-06 09:39 PST (History)
4 users (show)

See Also:


Attachments
Patch (22.25 KB, patch)
2018-12-06 07:45 PST, zalan
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-12-06 07:44:02 PST
ssia
Comment 1 zalan 2018-12-06 07:45:54 PST
Created attachment 356727 [details]
Patch
Comment 2 Antti Koivisto 2018-12-06 09:39:50 PST
Comment on attachment 356727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356727&action=review

> Source/WebCore/layout/blockformatting/BlockFormattingContext.h:108
> +            static bool marginTopCollapsesWithParent(const LayoutState&, const Box&);
> +            static bool marginTopCollapsesWithSibling(const Box&);
> +            static bool marginBottomCollapsesWithSibling(const Box&);
> +            static bool marginsCollapseThrough(const Box&);

Word 'margin' in these is a bit redundant.