Bug 192431 - Fix MiniBrowser's entitlements
Summary: Fix MiniBrowser's entitlements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: InRadar
: 187494 193159 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-12-05 14:46 PST by Benjamin Poulain
Modified: 2019-02-09 00:12 PST (History)
7 users (show)

See Also:


Attachments
Patch (1.82 KB, patch)
2018-12-05 14:49 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (1.31 KB, patch)
2019-02-08 22:23 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2018-12-05 14:46:56 PST
Fix MiniBrowser's entitlements
Comment 1 Benjamin Poulain 2018-12-05 14:49:06 PST
Created attachment 356661 [details]
Patch
Comment 2 Joseph Pecoraro 2019-02-08 15:14:32 PST
Comment on attachment 356661 [details]
Patch

r=me
Comment 3 Joseph Pecoraro 2019-02-08 15:15:02 PST
*** Bug 187494 has been marked as a duplicate of this bug. ***
Comment 4 Joseph Pecoraro 2019-02-08 15:15:18 PST
*** Bug 193159 has been marked as a duplicate of this bug. ***
Comment 5 WebKit Commit Bot 2019-02-08 22:11:53 PST
Comment on attachment 356661 [details]
Patch

Rejecting attachment 356661 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 356661, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=356661&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=192431&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 356661 from bug 192431.
Fetching: https://bugs.webkit.org/attachment.cgi?id=356661
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/MiniBrowser/MiniBrowser.entitlements
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file Tools/MiniBrowser/MiniBrowser.entitlements.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/11088193
Comment 6 Benjamin Poulain 2019-02-08 22:23:52 PST
Created attachment 361597 [details]
Patch
Comment 7 Benjamin Poulain 2019-02-08 22:24:20 PST
Thanks for the review Joe.
Comment 8 WebKit Commit Bot 2019-02-09 00:11:09 PST
Comment on attachment 361597 [details]
Patch

Clearing flags on attachment: 361597

Committed r241238: <https://trac.webkit.org/changeset/241238>
Comment 9 WebKit Commit Bot 2019-02-09 00:11:11 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-02-09 00:12:41 PST
<rdar://problem/47939735>