Bug 192430 - Move more macros out of WebKit's config.h
Summary: Move more macros out of WebKit's config.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-05 14:46 PST by Alexey Proskuryakov
Modified: 2018-12-10 09:56 PST (History)
7 users (show)

See Also:

Attachments
proposed patch (3.57 KB, patch)
2018-12-05 14:49 PST, Alexey Proskuryakov 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2018-12-05 14:46:24 PST 
Save some bug IDs by moving multiple macros at once!
Comment 1 Alexey Proskuryakov 2018-12-05 14:49:26 PST 
Created attachment 356662 [details]
proposed patch

These all seem straightforward.

Removing ifndefs, removing #else clauses, simplifying some of the conditions.
Comment 2 Tim Horton 2018-12-07 15:09:14 PST 
Comment on attachment 356662 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356662&action=review

> Source/WTF/wtf/Platform.h:1426
> +#if PLATFORM(IOS_FAMILY) || PLATFORM(MAC)

Cocoa
Comment 3 Alexey Proskuryakov 2018-12-10 09:55:50 PST 
Committed http://trac.webkit.org/r239034
Comment 4 Radar WebKit Bug Importer 2018-12-10 09:56:21 PST 
<rdar://problem/46598583>