Bug 192426 - Move USE_NEW_THEME out of WebCore's config.h
Summary: Move USE_NEW_THEME out of WebCore's config.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-05 14:10 PST by Alexey Proskuryakov
Modified: 2018-12-06 21:53 PST (History)
12 users (show)

See Also:

Attachments
proposed patch (2.36 KB, patch)
2018-12-05 14:11 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-sierra (2.41 MB, application/zip)
2018-12-05 19:56 PST, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2018-12-05 14:10:19 PST 
Platform specific USE macros live in Platform.h, not here.
Comment 1 Alexey Proskuryakov 2018-12-05 14:11:43 PST 
Created attachment 356655 [details]
proposed patch
Comment 2 EWS Watchlist 2018-12-05 19:56:44 PST 
Comment on attachment 356655 [details]
proposed patch

Attachment 356655 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10286800

New failing tests:
http/tests/misc/resource-timing-resolution.html
Comment 3 EWS Watchlist 2018-12-05 19:56:46 PST 
Created attachment 356702 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 Alexey Proskuryakov 2018-12-06 12:54:55 PST 
Test failure is unrelated.
Comment 5 Tim Horton 2018-12-06 13:51:11 PST 
Comment on attachment 356655 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356655&action=review

> Source/WTF/wtf/Platform.h:1427
> +/* FIXME: This really needs a descriptive name, this "new theme" was added in 2008. */

Agreed! And the refactor wasn't even completed, so this is really a bit of a mess.
Comment 6 WebKit Commit Bot 2018-12-06 21:51:39 PST 
Comment on attachment 356655 [details]
proposed patch

Clearing flags on attachment: 356655

Committed r238949: <https://trac.webkit.org/changeset/238949>
Comment 7 WebKit Commit Bot 2018-12-06 21:51:41 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-12-06 21:53:00 PST 
<rdar://problem/46546186>