Bug 192425 – [iOS] Add test to ensure that a web page can prevent the default for Command + A

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Daniel Bates]

We should add a test to ensure that a web page can prevent the default for Command + A. For now, we need to skip this test until we have the UIKit fix for <rdar://problem/46430796>.

[Daniel Bates]

Created attachment 356653 [details]
Layout test

[EWS Watchlist]

Comment on attachment 356653 [details]
Layout test

Attachment 356653 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10286576

New failing tests:
http/tests/misc/resource-timing-resolution.html

[EWS Watchlist]

Created attachment 356694 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Wenson Hsieh]

Comment on attachment 356653 [details]
Layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=356653&action=review

> LayoutTests/fast/events/ios/key-command-select-all-prevent-default.html:9
> +let testElement;

Nit - Is this necessary?

[Daniel Bates]

Committed r242800: <https://trac.webkit.org/changeset/242800>

[Radar WebKit Bug Importer]

<rdar://problem/48812610>

[Daniel Bates]

(In reply to Wenson Hsieh from comment #4)
> Comment on attachment 356653 [details]
> Layout test
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=356653&action=review
> 
> > LayoutTests/fast/events/ios/key-command-select-all-prevent-default.html:9
> > +let testElement;
> 
> Nit - Is this necessary?

No, I could have written the test to avoid it by making use of event.target. I explicitly chose to add this global because I felt it improves the readability of the code.