Bug 192425 - [iOS] Add test to ensure that a web page can prevent the default for Command + A
Summary: [iOS] Add test to ensure that a web page can prevent the default for Command + A
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 12
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks: 190571
  Show dependency treegraph
 
Reported: 2018-12-05 13:44 PST by Daniel Bates
Modified: 2019-03-12 10:25 PDT (History)
7 users (show)

See Also:


Attachments
Layout test (3.17 KB, patch)
2018-12-05 13:46 PST, Daniel Bates
wenson_hsieh: review+
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.68 MB, application/zip)
2018-12-05 19:03 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-12-05 13:44:03 PST
We should add a test to ensure that a web page can prevent the default for Command + A. For now, we need to skip this test until we have the UIKit fix for <rdar://problem/46430796>.
Comment 1 Daniel Bates 2018-12-05 13:46:04 PST
Created attachment 356653 [details]
Layout test
Comment 2 Build Bot 2018-12-05 19:03:41 PST
Comment on attachment 356653 [details]
Layout test

Attachment 356653 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10286576

New failing tests:
http/tests/misc/resource-timing-resolution.html
Comment 3 Build Bot 2018-12-05 19:03:43 PST
Created attachment 356694 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 Wenson Hsieh 2018-12-05 19:06:48 PST
Comment on attachment 356653 [details]
Layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=356653&action=review

> LayoutTests/fast/events/ios/key-command-select-all-prevent-default.html:9
> +let testElement;

Nit - Is this necessary?
Comment 5 Daniel Bates 2019-03-12 10:23:09 PDT
Committed r242800: <https://trac.webkit.org/changeset/242800>
Comment 6 Radar WebKit Bug Importer 2019-03-12 10:24:21 PDT
<rdar://problem/48812610>
Comment 7 Daniel Bates 2019-03-12 10:24:58 PDT
(In reply to Wenson Hsieh from comment #4)
> Comment on attachment 356653 [details]
> Layout test
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=356653&action=review
> 
> > LayoutTests/fast/events/ios/key-command-select-all-prevent-default.html:9
> > +let testElement;
> 
> Nit - Is this necessary?

No, I could have written the test to avoid it by making use of event.target. I explicitly chose to add this global because I felt it improves the readability of the code.