RESOLVED FIXED 192415
Remove unused API in NetworkProcess 
https://bugs.webkit.org/show_bug.cgi?id=192415
Summary Remove unused API in NetworkProcess
Rob Buis
Reported 2018-12-05 11:23:49 PST
Remove unused API in NetworkProcess.
Attachments
Patch (11.99 KB, patch)
2018-12-05 11:25 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews105 for mac-sierra-wk2 (3.18 MB, application/zip)
2018-12-05 12:32 PST, EWS Watchlist 		no flags
Details
Patch (33.30 KB, patch)
2018-12-07 05:51 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (33.02 KB, patch)
2018-12-07 06:08 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (31.94 KB, patch)
2018-12-07 08:21 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (31.19 KB, patch)
2018-12-07 10:05 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2018-12-05 11:25:51 PST
Created attachment 356627 [details] Patch
EWS Watchlist
Comment 2 2018-12-05 12:32:37 PST
Comment on attachment 356627 [details] Patch Attachment 356627 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10281139 New failing tests: http/tests/inspector/network/har/har-page.html http/tests/inspector/network/resource-request-headers.html
EWS Watchlist
Comment 3 2018-12-05 12:32:38 PST
Created attachment 356641 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Ryosuke Niwa
Comment 4 2018-12-05 13:43:59 PST
Comment on attachment 356627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356627&action=review > Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:-529 > - m_bytesReceived += buffer->size(); Why are you changing this line?
Rob Buis
Comment 5 2018-12-05 23:29:34 PST
(In reply to Ryosuke Niwa from comment #4) > Comment on attachment 356627 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=356627&action=review > > > Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:-529 > > - m_bytesReceived += buffer->size(); > > Why are you changing this line? m_bytesReceived keeps being written to, but nobody reads it, so I think it is pointless. It seems m_numBytesReceived has taken its place. Note that my patch is not final, I'll keep scanning for more API that can be removed, and will put up something for review later this week.
Rob Buis
Comment 6 2018-12-07 05:51:22 PST
Created attachment 356806 [details] Patch
Rob Buis
Comment 7 2018-12-07 06:08:51 PST
Created attachment 356807 [details] Patch
Rob Buis
Comment 8 2018-12-07 08:21:56 PST
Created attachment 356812 [details] Patch
Rob Buis
Comment 9 2018-12-07 10:05:37 PST
Created attachment 356817 [details] Patch
WebKit Commit Bot
Comment 10 2018-12-07 23:35:55 PST
Comment on attachment 356817 [details] Patch Clearing flags on attachment: 356817 Committed r239007: <https://trac.webkit.org/changeset/239007>
WebKit Commit Bot
Comment 11 2018-12-07 23:35:57 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2018-12-07 23:36:28 PST
<rdar://problem/46573271>
Note You need to log in before you can comment on or make changes to this bug.