Bug 192403 - Add some sanity checks inside WebBackForwardList::addItem()
Summary: Add some sanity checks inside WebBackForwardList::addItem()
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-05 09:18 PST by Chris Dumez
Modified: 2018-12-05 09:30 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.09 KB, patch)
2018-12-05 09:19 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-12-05 09:18:58 PST 
Add some sanity checks inside WebBackForwardList::addItem() to help debug <rdar://problem/46399319>. This crash seems to indicate that WebBackForwardList::m_entries can contain duplicate entries somehow.
Comment 1 Chris Dumez 2018-12-05 09:19:58 PST 
Created attachment 356611 [details]
Patch
Comment 2 EWS Watchlist 2018-12-05 09:22:08 PST 
Attachment 356611 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/WebBackForwardList.cpp:95:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit/UIProcess/WebBackForwardList.cpp:164:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.