Bug 192390 - Web Inspector: SelectionController should not extend the selection when allowsMultipleSelection is false
Summary: Web Inspector: SelectionController should not extend the selection when allow...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P3 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-04 18:13 PST by Matt Baker
Modified: 2018-12-05 15:50 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.50 KB, patch)
2018-12-04 18:21 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2018-12-04 18:13:57 PST 
Summary:
SelectionController should not extend the selection when allowsMultipleSelection is false.

Note:
It isn't possible to circumvent the `allowsMultipleSelection` flag using the UI (by shift/command-clicking). This change will prevent circumventing the flag by setting `extendSelection = true` when calling `SelectionController.prototype.selectItem`.
Comment 1 Radar WebKit Bug Importer 2018-12-04 18:14:31 PST 
<rdar://problem/46473624>
Comment 2 Matt Baker 2018-12-04 18:21:46 PST 
Created attachment 356567 [details]
Patch
Comment 3 Devin Rousso 2018-12-05 15:24:28 PST 
Comment on attachment 356567 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-12-05 15:50:16 PST 
Comment on attachment 356567 [details]
Patch

Clearing flags on attachment: 356567

Committed r238914: <https://trac.webkit.org/changeset/238914>
Comment 5 WebKit Commit Bot 2018-12-05 15:50:17 PST 
All reviewed patches have been landed.  Closing bug.