Bug 192386 - DFG's StrengthReduction phase should not reduce Construct into DirectContruct when the executable does not have constructAbility.
Summary: DFG's StrengthReduction phase should not reduce Construct into DirectContruct...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-04 15:06 PST by Mark Lam
Modified: 2018-12-04 19:24 PST (History)
9 users (show)

See Also:

Attachments
proposed patch. (2.68 KB, patch)
2018-12-04 15:16 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-12-04 15:06:08 PST 
This violates an invariant documented by a RELEASE_ASSERT in operationLinkDirectCall().

<rdar://problem/46445516>
Comment 1 Mark Lam 2018-12-04 15:16:42 PST 
Created attachment 356544 [details]
proposed patch.
Comment 2 Mark Lam 2018-12-04 18:57:32 PST 
Comment on attachment 356544 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 3 WebKit Commit Bot 2018-12-04 19:24:01 PST 
Comment on attachment 356544 [details]
proposed patch.

Clearing flags on attachment: 356544

Committed r238884: <https://trac.webkit.org/changeset/238884>
Comment 4 WebKit Commit Bot 2018-12-04 19:24:03 PST 
All reviewed patches have been landed.  Closing bug.