Bug 192385 - Add "-o/--output" option to startup.py and new_tab.py benchmark scripts to save the results in json format.
Summary: Add "-o/--output" option to startup.py and new_tab.py benchmark scripts to sa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Macintosh macOS 10.14
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-04 15:03 PST by Suresh Koppisetty
Modified: 2018-12-17 15:07 PST (History)
6 users (show)

See Also:


Attachments
Patch (7.07 KB, patch)
2018-12-04 15:22 PST, Suresh Koppisetty
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.77 MB, application/zip)
2018-12-04 16:42 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Suresh Koppisetty 2018-12-04 15:03:46 PST
Sample json output for new tab benchmark script after running with 2 iterations and 2 groups. Values are in milliseconds.
{
    "NewTabBenchmark": {
        "metrics": {
            "Time": {
                "current": [
                    [
                        410.2939453125,
                        307.81494140625
                    ],
                    [
                        340.616943359375,
                        265.94384765625
                    ]
                ]
            }
        }
    }
}

Sample json output for startup time benchmark script after running with 2 iterations. Values are in milliseconds.
{
    "StartupBenchmark": {
        "metrics": {
            "Time": {
                "current": [
                    [
                        1415.2099609375,
                        1439.552978515625
                    ]
                ]
            }
        }
    }
}
Comment 1 Suresh Koppisetty 2018-12-04 15:22:24 PST
Created attachment 356545 [details]
Patch
Comment 2 Suresh Koppisetty 2018-12-04 16:42:00 PST
Comment on attachment 356545 [details]
Patch

Thanks Ryosuke for reviewing. I don't think I have privileges to commit it manually. 

commit-queue ?
Comment 3 Build Bot 2018-12-04 16:42:32 PST
Comment on attachment 356545 [details]
Patch

Attachment 356545 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10270583

New failing tests:
http/tests/misc/resource-timing-resolution.html
Comment 4 Build Bot 2018-12-04 16:42:40 PST
Created attachment 356552 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 WebKit Commit Bot 2018-12-17 15:06:54 PST
Comment on attachment 356545 [details]
Patch

Clearing flags on attachment: 356545

Committed r239293: <https://trac.webkit.org/changeset/239293>
Comment 6 WebKit Commit Bot 2018-12-17 15:06:56 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-12-17 15:07:36 PST
<rdar://problem/46791803>