RESOLVED FIXED 192380
Make WebsiteDataStoreConfiguration a proper API object 
https://bugs.webkit.org/show_bug.cgi?id=192380
Summary Make WebsiteDataStoreConfiguration a proper API object
Alex Christensen
Reported 2018-12-04 14:24:38 PST
Make WebsiteDataStoreConfiguration a proper API object
Attachments
Patch (72.70 KB, patch)
2018-12-04 14:27 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (76.67 KB, patch)
2018-12-04 15:36 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (80.21 KB, patch)
2018-12-04 16:07 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (82.83 KB, patch)
2018-12-04 17:03 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (82.87 KB, patch)
2018-12-04 17:09 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (82.87 KB, patch)
2018-12-04 17:28 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (82.91 KB, patch)
2018-12-04 17:33 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (87.87 KB, patch)
2018-12-05 10:19 PST, Alex Christensen 		youennf: review+
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-12-04 14:27:09 PST
Created attachment 356533 [details] Patch
Alex Christensen
Comment 2 2018-12-04 15:36:01 PST
Created attachment 356546 [details] Patch
EWS Watchlist
Comment 3 2018-12-04 15:38:23 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alex Christensen
Comment 4 2018-12-04 16:07:30 PST
Created attachment 356549 [details] Patch
Alex Christensen
Comment 5 2018-12-04 17:03:04 PST
Created attachment 356556 [details] Patch
Alex Christensen
Comment 6 2018-12-04 17:09:13 PST
Created attachment 356559 [details] Patch
Alex Christensen
Comment 7 2018-12-04 17:28:24 PST
Created attachment 356561 [details] Patch
Alex Christensen
Comment 8 2018-12-04 17:33:56 PST
Created attachment 356562 [details] Patch
Chris Dumez
Comment 9 2018-12-05 08:45:40 PST
Comment on attachment 356562 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356562&action=review > Source/WebKit/ChangeLog:3 > + Make WebsiteDataStoreConfiguration a proper API object Could you please document in the changeling WHY you are making this change? What are the benefits?
youenn fablet
Comment 10 2018-12-05 08:52:55 PST
Comment on attachment 356562 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356562&action=review > Source/WebKit/ChangeLog:3 > + Make WebsiteDataStoreConfiguration a proper API object Is the idea to have a cleaner/easier to use API or are we expecting to expose additional functionality? > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:93 > + , m_configuration(m_resolvedConfiguration.copyRef()) Previously m_configuration and m_resolvedConfiguration were two separate objects but they are now more or less the same thing in this code path. Should we deep copy configuration in m_configuration?
Alex Christensen
Comment 11 2018-12-05 10:19:37 PST
Created attachment 356616 [details] Patch
Alex Christensen
Comment 12 2018-12-05 10:42:34 PST
http://trac.webkit.org/r238900
Radar WebKit Bug Importer
Comment 13 2018-12-05 10:43:42 PST
<rdar://problem/46492185>
Note You need to log in before you can comment on or make changes to this bug.