Bug 192378 - Import FeedbackServer only if "-f/--feedback-in-browser" option is enabled.
Summary: Import FeedbackServer only if "-f/--feedback-in-browser" option is enabled.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Macintosh macOS 10.14
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-04 14:12 PST by Suresh Koppisetty
Modified: 2018-12-17 15:02 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.25 KB, patch)
2018-12-04 14:28 PST, Suresh Koppisetty
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Suresh Koppisetty 2018-12-04 14:12:21 PST
FeedbackServer currently depends on Tornado-5.1, which further adds dependency of "singledispatch", "backports-abc" and "futures" python libraries. Importing FeedbackServer only if "-f/--feedback-in-browser" option is enabled will let us run the benchmark scripts without installing any new python libraries.
Comment 1 Suresh Koppisetty 2018-12-04 14:28:14 PST
Created attachment 356534 [details]
Patch
Comment 2 WebKit Commit Bot 2018-12-17 15:01:52 PST
Comment on attachment 356534 [details]
Patch

Clearing flags on attachment: 356534

Committed r239292: <https://trac.webkit.org/changeset/239292>
Comment 3 WebKit Commit Bot 2018-12-17 15:01:53 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-12-17 15:02:59 PST
<rdar://problem/46791637>