Bug 192371 – Fix MediaRecorder flaky tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Fix MediaRecorder flaky tests

[youenn fablet]

Created attachment 356523 [details]
Patch

[youenn fablet]

Created attachment 356525 [details]
Patch for landing

[youenn fablet]

(In reply to youenn fablet from comment #2)
> Created attachment 356525 [details]
> Patch for landing

Increased timers compared to first patch for improved stability.

[WebKit Commit Bot]

Comment on attachment 356525 [details]
Patch for landing

Clearing flags on attachment: 356525

Committed r238874: <https://trac.webkit.org/changeset/238874>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46464224>

[Ryan Haddad]

Since this change:

http/wpt/mediarecorder/MediaRecorder-AV-video-only-dataavailable.html is frequently failing on Sierra:

--- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/wpt/mediarecorder/MediaRecorder-AV-video-only-dataavailable-expected.txt
+++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/wpt/mediarecorder/MediaRecorder-AV-video-only-dataavailable-actual.txt
@@ -1,4 +1,5 @@
+CONSOLE MESSAGE: line 2659: Error: assert_approx_equals: Red channel of the pixel at (20, 20) expected 255 +/- 50 but got 0
 
 
-PASS MediaRecorder can successfully record the video for a video-only stream 
+FAIL MediaRecorder can successfully record the video for a video-only stream Error: assert_approx_equals: Red channel of the pixel at (20, 20) expected 255 +/- 50 but got 0

https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/8878



http/wpt/mediarecorder/MediaRecorder-AV-audio-only-dataavailable.html continues to be a flaky crash: https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r238881%20(1205)/results.html

http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html has failed once on Mojave:

--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-actual.txt
@@ -1,4 +1,5 @@
+CONSOLE MESSAGE: line 2659: Error: assert_approx_equals: Red channel of the pixel at (20, 20) expected 255 +/- 50 but got 0
 
 
-PASS MediaRecorder can successfully record the video for a audio-video stream 
+FAIL MediaRecorder can successfully record the video for a audio-video stream Error: assert_approx_equals: Red channel of the pixel at (20, 20) expected 255 +/- 50 but got 0
 
https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r238892%20(1216)/results.html

[WebKit Commit Bot]

Re-opened since this is blocked by bug 192414