Bug 192371 - Fix MediaRecorder flaky tests
Summary: Fix MediaRecorder flaky tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 192414
Blocks:
  Show dependency tree / graph
 
Reported: 2018-12-04 11:41 PST by youenn fablet
Modified: 2018-12-18 17:29 PST (History)
7 users (show)

See Also:

Attachments
Patch (21.13 KB, patch)
2018-12-04 11:45 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (21.03 KB, patch)
2018-12-04 13:03 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-12-04 11:41:21 PST 
Fix MediaRecorder flaky tests
Comment 1 youenn fablet 2018-12-04 11:45:23 PST 
Created attachment 356523 [details]
Patch
Comment 2 youenn fablet 2018-12-04 13:03:00 PST 
Created attachment 356525 [details]
Patch for landing
Comment 3 youenn fablet 2018-12-04 13:03:36 PST 
(In reply to youenn fablet from comment #2)
> Created attachment 356525 [details]
> Patch for landing

Increased timers compared to first patch for improved stability.
Comment 4 WebKit Commit Bot 2018-12-04 13:40:51 PST 
Comment on attachment 356525 [details]
Patch for landing

Clearing flags on attachment: 356525

Committed r238874: <https://trac.webkit.org/changeset/238874>
Comment 5 WebKit Commit Bot 2018-12-04 13:40:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-12-04 13:41:29 PST 
<rdar://problem/46464224>
Comment 7 Ryan Haddad 2018-12-05 11:04:54 PST 
Since this change:

http/wpt/mediarecorder/MediaRecorder-AV-video-only-dataavailable.html is frequently failing on Sierra:

--- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/wpt/mediarecorder/MediaRecorder-AV-video-only-dataavailable-expected.txt
+++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/http/wpt/mediarecorder/MediaRecorder-AV-video-only-dataavailable-actual.txt
@@ -1,4 +1,5 @@
+CONSOLE MESSAGE: line 2659: Error: assert_approx_equals: Red channel of the pixel at (20, 20) expected 255 +/- 50 but got 0
 
 
-PASS MediaRecorder can successfully record the video for a video-only stream 
+FAIL MediaRecorder can successfully record the video for a video-only stream Error: assert_approx_equals: Red channel of the pixel at (20, 20) expected 255 +/- 50 but got 0

https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/8878



http/wpt/mediarecorder/MediaRecorder-AV-audio-only-dataavailable.html continues to be a flaky crash: https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r238881%20(1205)/results.html

http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html has failed once on Mojave:

--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-actual.txt
@@ -1,4 +1,5 @@
+CONSOLE MESSAGE: line 2659: Error: assert_approx_equals: Red channel of the pixel at (20, 20) expected 255 +/- 50 but got 0
 
 
-PASS MediaRecorder can successfully record the video for a audio-video stream 
+FAIL MediaRecorder can successfully record the video for a audio-video stream Error: assert_approx_equals: Red channel of the pixel at (20, 20) expected 255 +/- 50 but got 0
 
https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r238892%20(1216)/results.html
Comment 8 WebKit Commit Bot 2018-12-05 11:16:30 PST 
Re-opened since this is blocked by bug 192414