Bug 192341 - Web Inspector: Audit: sidebar briefly shows "No Filter Results" before populating default audits
Summary: Web Inspector: Audit: sidebar briefly shows "No Filter Results" before popula...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P4 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-03 16:30 PST by Matt Baker
Modified: 2018-12-03 20:07 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.25 KB, patch)
2018-12-03 19:07 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2018-12-03 16:30:09 PST 
Steps to Reproduce:
1. Select Audit tab
2. Close Inspector
3. Reopen Inspector
  => "No Filter Results" flashes before populating sidebar

1. Select Elements tab
2. Close Inspector
3. Reopen Inspector
4. Select Audit tab
  => "No Filter Results" flashes before populating sidebar
Comment 1 Radar WebKit Bug Importer 2018-12-03 16:31:04 PST 
<rdar://problem/46436550>
Comment 2 Devin Rousso 2018-12-03 18:52:09 PST 
This is somewhat expected, as the `WI.ObjectStore` is async and will probably take a moment to load its data.

The "No Filter Results" is appearing because we do add a `WI.TreeElement` for the "Results" folder in `initialLayout`, which is default hidden, therefore triggering the placeholder.  We can improve this by delaying it's creation (and append) till it's needed.
Comment 3 Devin Rousso 2018-12-03 19:07:41 PST 
Created attachment 356446 [details]
Patch
Comment 4 Matt Baker 2018-12-03 19:27:33 PST 
Comment on attachment 356446 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2018-12-03 20:07:01 PST 
Comment on attachment 356446 [details]
Patch

Clearing flags on attachment: 356446

Committed r238842: <https://trac.webkit.org/changeset/238842>
Comment 6 WebKit Commit Bot 2018-12-03 20:07:03 PST 
All reviewed patches have been landed.  Closing bug.