Bug 192336 – Fix some unused parameter warnings

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Don Olmstead]

Found these while building for PlayStation.

[Don Olmstead]

Created attachment 356422 [details]
Patch

[Don Olmstead]

Created attachment 356423 [details]
Patch

[Michael Catanzaro]

Comment on attachment 356423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356423&action=review

> Source/WTF/wtf/generic/MemoryPressureHandlerGeneric.cpp:34
> -void MemoryPressureHandler::platformReleaseMemory(Critical)
> +void MemoryPressureHandler::platformReleaseMemory(Critical critical)
>  {
> +    UNUSED_PARAM(critical);
>  }

UNUSED_PARAM() exists for use with #ifdefs. Without #ifdefs, you can just not name the parameter. So I think you didn't need any changes in this hunk.

> Source/WTF/wtf/generic/MemoryPressureHandlerGeneric.cpp:47
>  void MemoryPressureHandler::holdOff(Seconds seconds)
>  {
> +    UNUSED_PARAM(seconds);
>  }

Better to remove the parameter name:

void MemoryPressureHandler::holdOff(Seconds)

> Source/WTF/wtf/generic/MemoryPressureHandlerGeneric.cpp:53
>  void MemoryPressureHandler::respondToMemoryPressure(Critical critical, Synchronous synchronous)
>  {
> +    UNUSED_PARAM(critical);
> +    UNUSED_PARAM(synchronous);
>  }

Again, better to remove the parameter names.

> Source/WebCore/platform/network/curl/CertificateInfo.h:87
>  template<> struct Coder<WebCore::CertificateInfo> {
>      static void encode(Encoder& encoder, const WebCore::CertificateInfo& certificateInfo)
>      {
> +        UNUSED_PARAM(encoder);
> +        UNUSED_PARAM(certificateInfo);
>          notImplemented();
>      }
>  
>      static bool decode(Decoder& decoder, WebCore::CertificateInfo& certificateInfo)
>      {
> +        UNUSED_PARAM(decoder);
> +        UNUSED_PARAM(certificateInfo);
>          notImplemented();
>          return false;
>      }

Again, best just remove the parameter names.

[Don Olmstead]

Created attachment 356430 [details]
Patch

Fixing review comments

[WebKit Commit Bot]

Comment on attachment 356430 [details]
Patch

Clearing flags on attachment: 356430

Committed r238836: <https://trac.webkit.org/changeset/238836>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46440021>