Bug 192334 - CSS Properties and Values API should support animating registered custom properties without any references
Summary: CSS Properties and Values API should support animating registered custom prop...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Michaud
URL:
Keywords:
Depends on: 192828
Blocks: 192324
  Show dependency treegraph
 
Reported: 2018-12-03 14:56 PST by Justin Michaud
Modified: 2018-12-18 13:51 PST (History)
6 users (show)

See Also:


Attachments
Patch (49.70 KB, patch)
2018-12-05 19:28 PST, Justin Michaud
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.50 MB, application/zip)
2018-12-05 20:38 PST, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.69 MB, application/zip)
2018-12-05 21:04 PST, Build Bot
no flags Details
Archive of layout-test-results from ews116 for mac-sierra (2.25 MB, application/zip)
2018-12-05 21:29 PST, Build Bot
no flags Details
Archive of layout-test-results from ews203 for win-future (12.78 MB, application/zip)
2018-12-05 21:41 PST, Build Bot
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.43 MB, application/zip)
2018-12-06 00:29 PST, Build Bot
no flags Details
Patch (61.98 KB, patch)
2018-12-10 22:34 PST, Justin Michaud
justin_michaud: review?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Michaud 2018-12-03 14:56:41 PST
Properties that are not used in substitutions should be able to be transitioned. This blocks 192324.
Comment 1 Justin Michaud 2018-12-05 19:28:23 PST
Created attachment 356699 [details]
Patch
Comment 2 Build Bot 2018-12-05 19:31:13 PST Comment hidden (obsolete)
Comment 3 Justin Michaud 2018-12-05 19:31:26 PST
This patch is not complete yet. In particular, I would like to have the wpt tests for css variables imported first, to make sure nothing breaks.

Right now, I have debug assertions everywhere just to aid in debugging. WebAnimations as well as declarative animations are not implemented yet. 

I am uploading this to get some preliminary feedback while I import the wpt tests and fix those bugs.
Comment 4 Simon Fraser (smfr) 2018-12-05 19:41:19 PST
Comment on attachment 356699 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356699&action=review

> Source/WebCore/animation/AnimationTimeline.cpp:380
> +void AnimationTimeline::updateCustomPropertyCSSTransitionsForElement(Element& element, const RenderStyle& currentStyle, const RenderStyle& afterChangeStyle)

Holy shit.

> Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1874
> +    return (!aValue && !bValue) || (aValue && bValue && *aValue == *bValue);

We have a thing for this: arePointingToEqualData()
Comment 5 Build Bot 2018-12-05 20:38:03 PST Comment hidden (obsolete)
Comment 6 Build Bot 2018-12-05 20:38:05 PST Comment hidden (obsolete)
Comment 7 Build Bot 2018-12-05 21:04:38 PST Comment hidden (obsolete)
Comment 8 Build Bot 2018-12-05 21:04:40 PST Comment hidden (obsolete)
Comment 9 Build Bot 2018-12-05 21:29:24 PST Comment hidden (obsolete)
Comment 10 Build Bot 2018-12-05 21:29:25 PST Comment hidden (obsolete)
Comment 11 Build Bot 2018-12-05 21:41:26 PST Comment hidden (obsolete)
Comment 12 Build Bot 2018-12-05 21:41:38 PST Comment hidden (obsolete)
Comment 13 Build Bot 2018-12-06 00:29:47 PST Comment hidden (obsolete)
Comment 14 Build Bot 2018-12-06 00:29:49 PST Comment hidden (obsolete)
Comment 15 Justin Michaud 2018-12-10 22:34:16 PST
Created attachment 357034 [details]
Patch
Comment 16 Justin Michaud 2018-12-10 22:35:03 PST
This is beautiful.