192321 – Support css-color-4 rgb functions

RESOLVED FIXED 192321

Support css-color-4 rgb functions

https://bugs.webkit.org/show_bug.cgi?id=192321

Summary Support css-color-4 rgb functions

Simon Fraser (smfr)

Reported 2018-12-03 13:57:02 PST

We should support "rgba(7, 8, 9, 50%)" in colors. Other browsers do.

Attachments
Testcase (279 bytes, text/html) 2018-12-03 13:57 PST, Simon Fraser (smfr)	no flags	Details
Patch (55.45 KB, patch) 2018-12-26 12:10 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (4.15 MB, application/zip) 2018-12-26 13:14 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (4.70 MB, text/plain) 2018-12-26 13:24 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews116 for mac-sierra (3.70 MB, application/zip) 2018-12-26 14:02 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews203 for win-future (14.45 MB, application/zip) 2018-12-26 14:02 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.87 MB, application/zip) 2018-12-26 14:11 PST, EWS Watchlist	no flags	Details
Patch (2.41 MB, patch) 2018-12-26 20:59 PST, Simon Fraser (smfr)	zalan: review+	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2018-12-03 13:57:44 PST

Created attachment 356403 [details] Testcase

Simon Fraser (smfr)

Comment 2 2018-12-26 12:10:26 PST

Created attachment 358081 [details] Patch

EWS Watchlist

Comment 3 2018-12-26 13:14:28 PST Comment hidden (obsolete)

Comment on attachment 358081 [details] Patch Attachment 358081 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10553336 New failing tests: canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-7.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-2.html css2.1/t040306-syntax-01-f.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-4.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-2.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-4.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-7.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-1.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-1.html svg/hixie/perf/007.xml

EWS Watchlist

Comment 4 2018-12-26 13:14:30 PST Comment hidden (obsolete)

Created attachment 358083 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-12-26 13:24:07 PST Comment hidden (obsolete)

Comment on attachment 358081 [details] Patch Attachment 358081 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10553347 New failing tests: canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-7.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-2.html css2.1/t040306-syntax-01-f.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-4.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-2.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-4.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-7.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-1.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-1.html svg/hixie/perf/007.xml

EWS Watchlist

Comment 6 2018-12-26 13:24:09 PST Comment hidden (obsolete)

Created attachment 358084 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-12-26 14:02:33 PST Comment hidden (obsolete)

Comment on attachment 358081 [details] Patch Attachment 358081 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/10553566 New failing tests: canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-7.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-2.html css2.1/t040306-syntax-01-f.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-4.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-2.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-4.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-7.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-1.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-1.html svg/hixie/perf/007.xml

EWS Watchlist

Comment 8 2018-12-26 14:02:42 PST Comment hidden (obsolete)

Comment on attachment 358081 [details] Patch Attachment 358081 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10553482 New failing tests: canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-7.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-2.html css2.1/t040306-syntax-01-f.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-4.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-2.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-4.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-7.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-1.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-1.html svg/hixie/perf/007.xml

EWS Watchlist

Comment 9 2018-12-26 14:02:44 PST Comment hidden (obsolete)

Created attachment 358086 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 10 2018-12-26 14:02:45 PST Comment hidden (obsolete)

Created attachment 358087 [details] Archive of layout-test-results from ews203 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews203 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

EWS Watchlist

Comment 11 2018-12-26 14:11:32 PST Comment hidden (obsolete)

Comment on attachment 358081 [details] Patch Attachment 358081 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10553487 New failing tests: canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-7.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-2.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-2.html css2.1/t040306-syntax-01-f.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-4.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-2.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-4.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-5.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-7.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgb-1.html canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-1.html imported/w3c/canvas/2d.fillStyle.parse.invalid.rgba-1.html

EWS Watchlist

Comment 12 2018-12-26 14:11:34 PST Comment hidden (obsolete)

Created attachment 358088 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Simon Fraser (smfr)

Comment 13 2018-12-26 20:59:53 PST

Created attachment 358098 [details] Patch

zalan

Comment 14 2019-01-02 11:00:39 PST

Comment on attachment 358098 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358098&action=review > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:511 > + auto consumeSeparator = [&] () -> bool { wouldn't "auto consumeSeparator = [&] {" just work? > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:533 > + auto consumeAlphaSeparator = [&] () { () can be dropped.

Simon Fraser (smfr)

Comment 15 2019-01-02 13:00:18 PST

https://trac.webkit.org/r239574

Radar WebKit Bug Importer

Comment 16 2019-01-02 13:01:44 PST

<rdar://problem/47008951>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component CSS

Assignee

Simon Fraser (smfr)

Reported

2018-12-03 13:57 PST

Modified

2019-01-02 13:01 PST History

CC List

9 users Show

URL

Keywords BrowserCompat, InRadar

Depends on

Blocks