Bug 192317 - Web Inspector: Audit: navigating while tests are running should stop and clear all results
Summary: Web Inspector: Audit: navigating while tests are running should stop and clea...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: WebInspectorAuditTab
Blocks:
  Show dependency treegraph
 
Reported: 2018-12-03 12:34 PST by Devin Rousso
Modified: 2018-12-03 20:06 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.64 KB, patch)
2018-12-03 17:06 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-12-03 12:34:25 PST
# STEPS TO REPRODUCE
1. open WebInspector
2. enable the Audit tab
3. load the default audits
4. start running the test
5. refresh the page
 => any tests with results are cleared, but all active tests (e.g. one's that have been queued but not yet run) continue running

# NOTE
For (4), it may be necessary to add an `await Promise.delay(1000)` inside `WI.AuditTestCase.prototype.run`, as the audits can run quite fast
Comment 1 Radar WebKit Bug Importer 2018-12-03 15:57:59 PST
<rdar://problem/46435222>
Comment 2 Devin Rousso 2018-12-03 17:06:40 PST
Created attachment 356440 [details]
Patch
Comment 3 Joseph Pecoraro 2018-12-03 18:13:34 PST
Comment on attachment 356440 [details]
Patch

r=me

You could write a test for this, but it seems like it could be rather artificial.
Comment 4 Devin Rousso 2018-12-03 19:43:11 PST
Comment on attachment 356440 [details]
Patch

(In reply to Joseph Pecoraro from comment #3) 
> You could write a test for this, but it seems like it could be rather artificial.
I'd need to wait for <https://webkit.org/b/192171> to land, as I'd need to create a long test that doesn't interfere with the page (e.g. a `setTimeout`), and I'd imagine that that would be pretty flakey.
Comment 5 WebKit Commit Bot 2018-12-03 20:06:38 PST
Comment on attachment 356440 [details]
Patch

Clearing flags on attachment: 356440

Committed r238841: <https://trac.webkit.org/changeset/238841>
Comment 6 WebKit Commit Bot 2018-12-03 20:06:40 PST
All reviewed patches have been landed.  Closing bug.