Bug 192316 - Update libwebrtc up to 0d007d7c4f
Summary: Update libwebrtc up to 0d007d7c4f
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-03 11:55 PST by youenn fablet
Modified: 2018-12-07 15:38 PST (History)
6 users (show)

See Also:


Attachments
Patch (7.91 MB, patch)
2018-12-03 12:02 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (7.95 MB, patch)
2018-12-03 16:53 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (7.96 MB, patch)
2018-12-03 22:20 PST, youenn fablet
no flags Details | Formatted Diff | Diff
GTK patch (10.68 KB, patch)
2018-12-07 02:56 PST, Alejandro G. Castro
no flags Details | Formatted Diff | Diff
Patch with GTK changes (7.97 MB, patch)
2018-12-07 08:57 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (61.75 KB, patch)
2018-12-07 14:59 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-12-03 11:55:18 PST
Update libwebrtc up to 0d007d7c4f
Comment 1 youenn fablet 2018-12-03 12:02:15 PST
Created attachment 356390 [details]
Patch
Comment 2 youenn fablet 2018-12-03 16:53:03 PST
Created attachment 356436 [details]
Patch
Comment 3 youenn fablet 2018-12-03 22:20:46 PST
Created attachment 356469 [details]
Patch
Comment 4 Alejandro G. Castro 2018-12-07 02:56:07 PST
Created attachment 356793 [details]
GTK patch

This patch fixes compilation for GTK with the upgrade. I have also made some small test with webrtc in appr.tc and it works for chrome.
Comment 5 Alejandro G. Castro 2018-12-07 02:59:00 PST
Comment on attachment 356793 [details]
GTK patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356793&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc:84
>                             const char* tag) {
> -  OnLogMessage(tag + (": " + msg));
> +  OnLogMessage(tag + (": " + msg), severity);
> +}
> +
> +void LogSink::OnLogMessage(const std::string& msg,
> +                           LoggingSeverity /* severity */) {
> +  OnLogMessage(msg);
>  }

This change adds again code removed previously in WebKit, not sure the reason we removed this originally.

> Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/task_queue_libevent.cc:31
> +#if defined(WEBRTC_LINUX)
> +#include <event2/event.h>
> +#include <event2/event_compat.h>
> +#include <event2/event_struct.h>
> +#else
>  #include "base/third_party/libevent/event.h"
> +#endif

This is the usual requirement to use system libevent.
Comment 6 youenn fablet 2018-12-07 08:57:14 PST
Created attachment 356816 [details]
Patch with GTK changes
Comment 7 Eric Carlson 2018-12-07 12:01:00 PST
Comment on attachment 356816 [details]
Patch with GTK changes

rs=me once the bots are happy
Comment 8 WebKit Commit Bot 2018-12-07 13:44:44 PST
Comment on attachment 356816 [details]
Patch with GTK changes

Clearing flags on attachment: 356816

Committed r238967: <https://trac.webkit.org/changeset/238967>
Comment 9 WebKit Commit Bot 2018-12-07 13:44:46 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-12-07 13:45:41 PST
<rdar://problem/46563726>
Comment 11 youenn fablet 2018-12-07 14:59:50 PST
Reopening to attach new patch.
Comment 12 youenn fablet 2018-12-07 14:59:51 PST
Created attachment 356841 [details]
Patch
Comment 13 WebKit Commit Bot 2018-12-07 15:38:46 PST
Comment on attachment 356841 [details]
Patch

Clearing flags on attachment: 356841

Committed r238971: <https://trac.webkit.org/changeset/238971>
Comment 14 WebKit Commit Bot 2018-12-07 15:38:48 PST
All reviewed patches have been landed.  Closing bug.