Bug 192316 – Update libwebrtc up to 0d007d7c4f

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Update libwebrtc up to 0d007d7c4f

[youenn fablet]

Created attachment 356390 [details]
Patch

[youenn fablet]

Created attachment 356436 [details]
Patch

[youenn fablet]

Created attachment 356469 [details]
Patch

[Alejandro G. Castro]

Created attachment 356793 [details]
GTK patch

This patch fixes compilation for GTK with the upgrade. I have also made some small test with webrtc in appr.tc and it works for chrome.

[Alejandro G. Castro]

Comment on attachment 356793 [details]
GTK patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356793&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc:84
>                             const char* tag) {
> -  OnLogMessage(tag + (": " + msg));
> +  OnLogMessage(tag + (": " + msg), severity);
> +}
> +
> +void LogSink::OnLogMessage(const std::string& msg,
> +                           LoggingSeverity /* severity */) {
> +  OnLogMessage(msg);
>  }

This change adds again code removed previously in WebKit, not sure the reason we removed this originally.

> Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/task_queue_libevent.cc:31
> +#if defined(WEBRTC_LINUX)
> +#include <event2/event.h>
> +#include <event2/event_compat.h>
> +#include <event2/event_struct.h>
> +#else
>  #include "base/third_party/libevent/event.h"
> +#endif

This is the usual requirement to use system libevent.

[youenn fablet]

Created attachment 356816 [details]
Patch with GTK changes

[Eric Carlson]

Comment on attachment 356816 [details]
Patch with GTK changes

rs=me once the bots are happy

[WebKit Commit Bot]

Comment on attachment 356816 [details]
Patch with GTK changes

Clearing flags on attachment: 356816

Committed r238967: <https://trac.webkit.org/changeset/238967>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46563726>

[youenn fablet]

Reopening to attach new patch.

[youenn fablet]

Created attachment 356841 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 356841 [details]
Patch

Clearing flags on attachment: 356841

Committed r238971: <https://trac.webkit.org/changeset/238971>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.