Bug 192303 - [iOS] Handle hit testing for subframes
Summary: [iOS] Handle hit testing for subframes
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Event Handling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords:
Depends on: 173833
Blocks: 149264 182868
  Show dependency treegraph
 
Reported: 2018-12-03 00:34 PST by Frédéric Wang (:fredw)
Modified: 2018-12-03 14:52 PST (History)
2 users (show)

See Also:


Attachments
Patch (applies on top of bug 173833) (7.47 KB, patch)
2018-12-03 00:54 PST, Frédéric Wang (:fredw)
simon.fraser: review+
simon.fraser: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2018-12-03 00:34:58 PST
Extracting the windowToContents/contentToWindow changes from bug 173833. These are necessary to properly handle hit testing.
Comment 1 Frédéric Wang (:fredw) 2018-12-03 00:54:48 PST
Created attachment 356365 [details]
Patch (applies on top of bug 173833)

This has been extracted from attachment 356214 [details]
Comment 2 Simon Fraser (smfr) 2018-12-03 14:01:19 PST
Comment on attachment 356365 [details]
Patch (applies on top of bug 173833)

View in context: https://bugs.webkit.org/attachment.cgi?id=356365&action=review

> Source/WebCore/page/FrameView.h:682
> +    bool coordinateChangeShouldIgnoreScrollPosition() const final;

Please rename this to windowToContentsShouldIgnoreScrollPosition()
Comment 3 Frédéric Wang (:fredw) 2018-12-03 14:52:39 PST
Comment on attachment 356365 [details]
Patch (applies on top of bug 173833)

View in context: https://bugs.webkit.org/attachment.cgi?id=356365&action=review

>> Source/WebCore/page/FrameView.h:682
>> +    bool coordinateChangeShouldIgnoreScrollPosition() const final;
> 
> Please rename this to windowToContentsShouldIgnoreScrollPosition()

smfr: I can but note that as I said elsewhere the function might be needed in other siutations:

https://bugs.webkit.org/attachment.cgi?id=353085&action=review
https://bugs.webkit.org/attachment.cgi?id=348915&action=review

Anyway, this is blocked by bug 173833.