Bug 192283 - [iOSMac] Unable to upload non-image files using drag and drop in WKWebView
Summary: [iOSMac] Unable to upload non-image files using drag and drop in WKWebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-01 18:49 PST by Wenson Hsieh
Modified: 2018-12-03 07:57 PST (History)
7 users (show)

See Also:


Attachments
First pass (20.54 KB, patch)
2018-12-02 16:05 PST, Wenson Hsieh
rniwa: review+
Details | Formatted Diff | Diff
Patch for landing (20.53 KB, patch)
2018-12-03 07:04 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-12-01 18:49:06 PST
SSIA
Comment 1 Radar WebKit Bug Importer 2018-12-01 18:49:35 PST
<rdar://problem/46399461>
Comment 2 Wenson Hsieh 2018-12-02 16:05:27 PST
Created attachment 356350 [details]
First pass
Comment 3 Wenson Hsieh 2018-12-02 22:25:37 PST
Comment on attachment 356350 [details]
First pass

View in context: https://bugs.webkit.org/attachment.cgi?id=356350&action=review

Thanks for the review!

> Source/WebCore/ChangeLog:42
> +        If the pasteboard contains "public.file-url", don't consider "text-uri-list" to be one of the data types that's

Oops, I just noticed that I wrote "text-uri-list" here instead of "text/uri-list". I'll fix this typo before landing.

> Source/WebCore/ChangeLog:43
> +        safe to expose to the page. Our currently behavior in this case is that we will advertise "text-uri-list" as a

(here too)
Comment 4 Wenson Hsieh 2018-12-03 07:04:46 PST
Created attachment 356378 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-12-03 07:42:19 PST
Comment on attachment 356378 [details]
Patch for landing

Clearing flags on attachment: 356378

Committed r238795: <https://trac.webkit.org/changeset/238795>