Bug 192282 - Web Inspector: Add style editing debug mode
Summary: Web Inspector: Add style editing debug mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks: 191567
  Show dependency treegraph
 
Reported: 2018-12-01 17:32 PST by Nikita Vasilyev
Modified: 2018-12-04 17:37 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.56 KB, patch)
2018-12-01 17:51 PST, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
[Screenshot] Extra logging (141.27 KB, image/png)
2018-12-01 17:55 PST, Nikita Vasilyev
no flags Details
[Image] Locked rule (49.97 KB, image/png)
2018-12-01 17:56 PST, Nikita Vasilyev
no flags Details
Patch (6.56 KB, patch)
2018-12-01 17:57 PST, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
Patch (6.65 KB, patch)
2018-12-04 14:11 PST, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.68 MB, application/zip)
2018-12-04 15:01 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-12-01 17:32:13 PST
There are several bugs in style editing that are notoriously hard to debug.

Add a debug setting to:
- Enable extra logging.
- Visualize locked style declarations.
Comment 1 Radar WebKit Bug Importer 2018-12-01 17:33:29 PST
<rdar://problem/46399176>
Comment 2 Nikita Vasilyev 2018-12-01 17:51:21 PST
Created attachment 356327 [details]
Patch
Comment 3 Nikita Vasilyev 2018-12-01 17:55:37 PST
Created attachment 356328 [details]
[Screenshot] Extra logging

Here, there's an issue with repeating semicolons when toggling properties.
Comment 4 Nikita Vasilyev 2018-12-01 17:56:17 PST
Created attachment 356329 [details]
[Image] Locked rule
Comment 5 Nikita Vasilyev 2018-12-01 17:57:45 PST
Created attachment 356330 [details]
Patch
Comment 6 Nikita Vasilyev 2018-12-04 14:11:09 PST
Created attachment 356531 [details]
Patch

Rebaseline.
Comment 7 Build Bot 2018-12-04 15:01:28 PST
Comment on attachment 356531 [details]
Patch

Attachment 356531 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10269047

New failing tests:
workers/bomb.html
Comment 8 Build Bot 2018-12-04 15:01:30 PST
Created attachment 356542 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 9 Nikita Vasilyev 2018-12-04 15:06:39 PST
Comment on attachment 356531 [details]
Patch

Unrelated test failure.
Comment 10 Matt Baker 2018-12-04 16:36:35 PST
Comment on attachment 356531 [details]
Patch

r=me
Comment 11 WebKit Commit Bot 2018-12-04 17:37:11 PST
Comment on attachment 356531 [details]
Patch

Clearing flags on attachment: 356531

Committed r238882: <https://trac.webkit.org/changeset/238882>
Comment 12 WebKit Commit Bot 2018-12-04 17:37:13 PST
All reviewed patches have been landed.  Closing bug.