Bug 192280 - Add a runtime feature flag for LayoutFormattingContext.
Summary: Add a runtime feature flag for LayoutFormattingContext.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-01 14:09 PST by zalan
Modified: 2018-12-02 20:56 PST (History)
13 users (show)

See Also:

Attachments
Patch (11.48 KB, patch)
2018-12-01 14:15 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.18 KB, patch)
2018-12-01 14:37 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (13.88 KB, patch)
2018-12-01 18:47 PST, zalan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (85.05 MB, application/zip)
2018-12-02 06:56 PST, EWS Watchlist 		no flags Details
Patch (14.57 KB, patch)
2018-12-02 15:46 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-12-01 14:09:23 PST 
ssia
Comment 1 zalan 2018-12-01 14:15:53 PST 
Created attachment 356321 [details]
Patch
Comment 2 zalan 2018-12-01 14:37:52 PST 
Created attachment 356322 [details]
Patch
Comment 3 zalan 2018-12-01 16:23:36 PST 
Guess I never built LFC for release.
Comment 4 zalan 2018-12-01 18:47:53 PST 
Created attachment 356331 [details]
Patch
Comment 5 Simon Fraser (smfr) 2018-12-01 19:23:28 PST 
Comment on attachment 356331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356331&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1335
> +  category: experimental

internal for now, I think?
Comment 6 EWS Watchlist 2018-12-02 06:56:27 PST 
Comment on attachment 356331 [details]
Patch

Attachment 356331 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10238989

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall.https.html
Comment 7 EWS Watchlist 2018-12-02 06:56:31 PST 
Created attachment 356336 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 8 zalan 2018-12-02 15:46:15 PST 
Created attachment 356349 [details]
Patch
Comment 9 WebKit Commit Bot 2018-12-02 19:24:50 PST 
Comment on attachment 356349 [details]
Patch

Clearing flags on attachment: 356349

Committed r238791: <https://trac.webkit.org/changeset/238791>
Comment 10 WebKit Commit Bot 2018-12-02 19:24:52 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2018-12-02 19:25:56 PST 
<rdar://problem/46407388>
Comment 12 Don Olmstead 2018-12-02 19:48:53 PST 
Are there any details on LFC so other ports can determine whether or not they can or should enable it?
Comment 13 Don Olmstead 2018-12-02 19:48:53 PST Comment hidden (obsolete)
Comment 14 zalan 2018-12-02 20:01:47 PST 
(In reply to Don Olmstead from comment #13)
> Are there any details on LFC so other ports can determine whether or not
> they can or should enable it?
This is internal yet (not even an experimental feature). Nowhere near ready to turn it on (and even when it is on, it just runs as a secondary layout and the tree it generates gets verified against the original render tree.)
I am planning to write up a blog entry on this, but the short answer is no. No ports should enable it at this point.
Comment 15 Don Olmstead 2018-12-02 20:56:07 PST 
(In reply to zalan from comment #14)
> (In reply to Don Olmstead from comment #13)
> > Are there any details on LFC so other ports can determine whether or not
> > they can or should enable it?
> This is internal yet (not even an experimental feature). Nowhere near ready
> to turn it on (and even when it is on, it just runs as a secondary layout
> and the tree it generates gets verified against the original render tree.)
> I am planning to write up a blog entry on this, but the short answer is no.
> No ports should enable it at this point.

Thanks for the information! I saw this when I was looking at syncing the CMake and XCode feature set but was unsure what was happening.

Looking forward to the blog entry