Bug 192277 - [PSON] process-swapping may occur even though opener has handle to openee
Summary: [PSON] process-swapping may occur even though opener has handle to openee
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-12-01 10:52 PST by Chris Dumez
Modified: 2018-12-01 14:41 PST (History)
10 users (show)

See Also:


Attachments
Patch (23.04 KB, patch)
2018-12-01 11:01 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-12-01 10:52:02 PST
Process-swapping may occur even though opener has handle to openee, which is not Web-compatible. The reason is that we rely on the window not having an opener to process-swap. However, the opener can be disowned, which does not mean that the opener doesn't still have a handle to its openee.
Comment 1 Chris Dumez 2018-12-01 11:01:34 PST
Created attachment 356315 [details]
Patch
Comment 2 EWS Watchlist 2018-12-01 11:03:21 PST
Attachment 356315 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2980:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2988:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2018-12-01 14:40:16 PST
Comment on attachment 356315 [details]
Patch

Clearing flags on attachment: 356315

Committed r238787: <https://trac.webkit.org/changeset/238787>
Comment 4 WebKit Commit Bot 2018-12-01 14:40:17 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-12-01 14:41:33 PST
<rdar://problem/46398357>