Bug 192275 - Move URL tests from TestWebKitAPI to TestWTF
Summary: Move URL tests from TestWebKitAPI to TestWTF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-30 22:12 PST by Yusuke Suzuki
Modified: 2018-12-01 04:24 PST (History)
6 users (show)

See Also:

Attachments
Patch (282.13 KB, patch)
2018-11-30 22:13 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (281.15 KB, patch)
2018-11-30 23:07 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-11-30 22:12:05 PST 
Move URL tests from TestWebKitAPI to TestWTF
Comment 1 Yusuke Suzuki 2018-11-30 22:13:29 PST 
Created attachment 356293 [details]
Patch
Comment 2 EWS Watchlist 2018-11-30 22:15:32 PST 
Attachment 356293 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:530:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:530:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:533:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:533:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:688:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:688:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:689:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:689:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:692:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:692:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:39:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 11 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yusuke Suzuki 2018-11-30 23:07:04 PST 
Created attachment 356296 [details]
Patch
Comment 4 EWS Watchlist 2018-11-30 23:09:39 PST 
Attachment 356296 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:530:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:530:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:533:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:533:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:688:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:688:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:689:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:689:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:692:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:692:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 10 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Keith Miller 2018-12-01 03:54:15 PST 
Comment on attachment 356296 [details]
Patch

r=me
Comment 6 Yusuke Suzuki 2018-12-01 03:57:12 PST 
Comment on attachment 356296 [details]
Patch

thanks!
Comment 7 WebKit Commit Bot 2018-12-01 04:23:33 PST 
Comment on attachment 356296 [details]
Patch

Clearing flags on attachment: 356296

Committed r238779: <https://trac.webkit.org/changeset/238779>
Comment 8 WebKit Commit Bot 2018-12-01 04:23:35 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-12-01 04:24:43 PST 
<rdar://problem/46395626>