Bug 192272 - Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
Summary: Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with ...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-30 18:23 PST by Alex Christensen
Modified: 2019-01-31 12:57 PST (History)
11 users (show)

See Also:


Attachments
Patch (61.53 KB, patch)
2018-11-30 18:28 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.70 MB, application/zip)
2018-11-30 20:29 PST, EWS Watchlist
no flags Details
Patch (62.70 KB, patch)
2018-11-30 22:15 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (29.64 KB, patch)
2019-01-31 12:54 PST, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-11-30 18:23:56 PST
Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
Comment 1 Alex Christensen 2018-11-30 18:28:29 PST
Created attachment 356279 [details]
Patch
Comment 2 EWS Watchlist 2018-11-30 18:29:51 PST
Attachment 356279 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:84:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 EWS Watchlist 2018-11-30 20:29:28 PST
Comment on attachment 356279 [details]
Patch

Attachment 356279 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10224839

Number of test failures exceeded the failure limit.
Comment 4 EWS Watchlist 2018-11-30 20:29:30 PST
Created attachment 356287 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 Alex Christensen 2018-11-30 22:15:43 PST
Created attachment 356294 [details]
Patch
Comment 6 EWS Watchlist 2018-11-30 22:18:45 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 7 EWS Watchlist 2018-11-30 22:18:59 PST
Attachment 356294 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:84:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Alex Christensen 2018-12-03 13:47:21 PST
http://trac.webkit.org/r238819
Comment 9 Radar WebKit Bug Importer 2018-12-03 13:48:43 PST
<rdar://problem/46430401>
Comment 10 Alex Christensen 2019-01-31 12:54:09 PST
Reopening to attach new patch.
Comment 11 Alex Christensen 2019-01-31 12:54:10 PST
Created attachment 360758 [details]
Patch
Comment 12 EWS Watchlist 2019-01-31 12:57:36 PST
Attachment 360758 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:84:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.