Bug 192263 - Add generic implementations to FileSystemPOSIX.cpp
Summary: Add generic implementations to FileSystemPOSIX.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-30 15:57 PST by Christopher Reid
Modified: 2018-12-01 11:35 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.56 KB, patch)
2018-11-30 16:32 PST, Christopher Reid 		no flags Details | Formatted Diff | Diff
Patch (2.56 KB, patch)
2018-11-30 17:20 PST, Christopher Reid 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Reid 2018-11-30 15:57:19 PST 
Add generic POSIX implementations for stringFromFileSystemRepresentation, fileSystemRepresentation, moveFile, and getVolumeFreeSpace.
Comment 1 Christopher Reid 2018-11-30 16:32:18 PST 
Created attachment 356260 [details]
Patch
Comment 2 Christopher Reid 2018-11-30 17:04:47 PST 
I was wondering if any of these should replace cocoa's implementations.

stringFromFileSystemRepresentation is based off of CF's functionality on osx, Glib percent encodes most non-alphanumeric characters. There are however a couple of cases where CF's stringFromFileSystemRepresentation and String::fromUTF8 don't match with certain invalid utf-8 sequences.
Comment 3 Christopher Reid 2018-11-30 17:20:04 PST 
Created attachment 356267 [details]
Patch
Comment 4 Yusuke Suzuki 2018-12-01 04:32:06 PST 
Comment on attachment 356267 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2018-12-01 11:34:51 PST 
Comment on attachment 356267 [details]
Patch

Clearing flags on attachment: 356267

Committed r238782: <https://trac.webkit.org/changeset/238782>
Comment 6 WebKit Commit Bot 2018-12-01 11:34:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-12-01 11:35:37 PST 
<rdar://problem/46397333>