Bug 192255 - Web Inspector: resource combining should be more robust against missing WebKitAdditions
Summary: Web Inspector: resource combining should be more robust against missing WebKi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-30 14:21 PST by BJ Burg
Modified: 2018-12-03 11:13 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.47 KB, patch)
2018-11-30 14:24 PST, BJ Burg 		joepeck: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-sierra (2.54 MB, application/zip)
2018-11-30 18:00 PST, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2018-11-30 14:21:03 PST 
.
Comment 1 BJ Burg 2018-11-30 14:21:16 PST 
<rdar://problem/46042879>
Comment 2 BJ Burg 2018-11-30 14:24:35 PST 
Created attachment 356236 [details]
Patch
Comment 3 Alexey Proskuryakov 2018-11-30 14:30:40 PST 
Comment on attachment 356236 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356236&action=review

> Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:250
> +        $combineWebKitAdditions = 1 if $foundCSSFile and $foundJSFile;

Should this be "and", or "or"?

I'll leave actual reviewing to folks who know more about this logic and/or about Perl.
Comment 4 Joseph Pecoraro 2018-11-30 14:47:55 PST 
Comment on attachment 356236 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356236&action=review

r=me

>> Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:250
>> +        $combineWebKitAdditions = 1 if $foundCSSFile and $foundJSFile;
> 
> Should this be "and", or "or"?
> 
> I'll leave actual reviewing to folks who know more about this logic and/or about Perl.

Same question, I think an `or` might make sense here, as long as there is something we may want to proceed.
Comment 5 BJ Burg 2018-11-30 16:30:02 PST 
Comment on attachment 356236 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356236&action=review

>>> Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:250
>>> +        $combineWebKitAdditions = 1 if $foundCSSFile and $foundJSFile;
>> 
>> Should this be "and", or "or"?
>> 
>> I'll leave actual reviewing to folks who know more about this logic and/or about Perl.
> 
> Same question, I think an `or` might make sense here, as long as there is something we may want to proceed.

I'll change it to 'or'.
Comment 6 EWS Watchlist 2018-11-30 17:59:59 PST 
Comment on attachment 356236 [details]
Patch

Attachment 356236 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10223451

New failing tests:
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSASSA-PKCS1-v1_5.https.any.worker.html
webgl/2.0.0/conformance/more/conformance/quickCheckAPI-B2.html
inspector/indexeddb/requestData.html
Comment 7 EWS Watchlist 2018-11-30 18:00:00 PST 
Created attachment 356275 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 8 BJ Burg 2018-12-03 11:13:22 PST 
Committed r238806: <https://trac.webkit.org/changeset/238806>