Bug 192255 – Web Inspector: resource combining should be more robust against missing WebKitAdditions

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

.

[Blaze Burg]

<rdar://problem/46042879>

[Blaze Burg]

Created attachment 356236 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 356236 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356236&action=review

> Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:250
> +        $combineWebKitAdditions = 1 if $foundCSSFile and $foundJSFile;

Should this be "and", or "or"?

I'll leave actual reviewing to folks who know more about this logic and/or about Perl.

[Joseph Pecoraro]

Comment on attachment 356236 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356236&action=review

r=me

>> Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:250
>> +        $combineWebKitAdditions = 1 if $foundCSSFile and $foundJSFile;
> 
> Should this be "and", or "or"?
> 
> I'll leave actual reviewing to folks who know more about this logic and/or about Perl.

Same question, I think an `or` might make sense here, as long as there is something we may want to proceed.

[Blaze Burg]

Comment on attachment 356236 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356236&action=review

>>> Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:250
>>> +        $combineWebKitAdditions = 1 if $foundCSSFile and $foundJSFile;
>> 
>> Should this be "and", or "or"?
>> 
>> I'll leave actual reviewing to folks who know more about this logic and/or about Perl.
> 
> Same question, I think an `or` might make sense here, as long as there is something we may want to proceed.

I'll change it to 'or'.

[EWS Watchlist]

Comment on attachment 356236 [details]
Patch

Attachment 356236 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10223451

New failing tests:
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSASSA-PKCS1-v1_5.https.any.worker.html
webgl/2.0.0/conformance/more/conformance/quickCheckAPI-B2.html
inspector/indexeddb/requestData.html

[EWS Watchlist]

Created attachment 356275 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Blaze Burg]

Committed r238806: <https://trac.webkit.org/changeset/238806>