Bug 192254 - [WebGPU] WebGPUQueue::submit and WebGPURenderingContext::present() implementation
Summary: [WebGPU] WebGPUQueue::submit and WebGPURenderingContext::present() implementa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-30 14:16 PST by Justin Fan
Modified: 2018-11-30 16:12 PST (History)
6 users (show)

See Also:

Attachments
Patch (13.93 KB, patch)
2018-11-30 14:26 PST, Justin Fan 		no flags Details | Formatted Diff | Diff
Patch for landing (13.94 KB, patch)
2018-11-30 15:33 PST, Justin Fan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2018-11-30 14:16:37 PST 
[WebGPU] WebGPUQueue::submit and WebGPURenderingContext::present() implementation
Comment 1 Justin Fan 2018-11-30 14:26:19 PST 
Created attachment 356238 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-11-30 14:27:05 PST 
<rdar://problem/46384207>
Comment 3 Dean Jackson 2018-11-30 14:52:47 PST 
Comment on attachment 356238 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356238&action=review

> Source/WebCore/ChangeLog:17
> +        (WebCore::GPUSwapChain::metalLayer const): Renamed from platformLayer. 

As we discussed, we don't need this function.

> Source/WebCore/platform/graphics/gpu/GPUSwapChain.h:57
> +    CALayer *platformLayer() const;

We decided to:

using PlatformLayer = CALayer;

which will later be wrapped in platform #ifs.
Comment 4 Justin Fan 2018-11-30 15:33:13 PST 
Created attachment 356248 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-11-30 16:11:58 PST 
Comment on attachment 356248 [details]
Patch for landing

Clearing flags on attachment: 356248

Committed r238760: <https://trac.webkit.org/changeset/238760>
Comment 6 WebKit Commit Bot 2018-11-30 16:12:00 PST 
All reviewed patches have been landed.  Closing bug.